Remove all our quirk species whitelist code (#4030)

## About The Pull Request

Upstream now has a system for this, removes all our override code and
changes the relevant quirks to use the upstream system instead

## Why It's Good For The Game

Fixes #3732 

## Proof Of Testing

Tested it on a local with sol weakness, masquerade, and hydrophillic,
the latter wasn't selectable unless you were a slime, the former two
weren't selectable unless you were a hemophage. Sol weakness was still
removed as normal if you turned into a bloodsucker

## Changelog

🆑
fix: fixed species-locked quirks not actually working
/🆑
This commit is contained in:
Roxy
2025-06-13 16:55:48 -04:00
committed by GitHub
parent 0f6c3a1879
commit 5f18ba4881
11 changed files with 18 additions and 96 deletions
@@ -78,12 +78,6 @@
var/datum/quirk_constant_data/constant_data = GLOB.all_quirk_constant_data[quirk]
var/list/datum/preference/customization_options = constant_data?.get_customization_data()
// BUBBER EDIT START - Species only quirks
var/list/species_whitelist = list()
for(var/species_id in GLOB.quirk_species_whitelist[quirk])
var/datum/species/species_type = GLOB.species_list[species_id]
var/species_name = initial(species_type.name)
species_whitelist[species_id] += species_name // BUBBER EDIT END - Species only quirks
quirk_info[sanitize_css_class_name(quirk_name)] = list(
"description" = initial(quirk.desc),
"icon" = initial(quirk.icon),
@@ -91,7 +85,6 @@
"value" = initial(quirk.value),
"customizable" = constant_data?.is_customizable(),
"customization_options" = customization_options,
"species_whitelist" = species_whitelist, //BUBBER EDIT - Species quirks
)
return list(