cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-23 05:00:55 +01:00
Code Issues Packages Projects Releases Wiki Activity

[MIRROR] Color standardization, vars moved, and signals (#194)

Browse Source 
* Color standardization, vars moved, and signals (#52574)

    Defined all the existing light_color values.
    Moved their definitions to colors.dm
    Made white the default color. It was so already, but that was very obscured.
    Moved the atom light-related variables to the atom definition.
    Wrapped changes to variables such as light_color into procs that report the event through signals.
    Moved the light_on variable to the atom level, also adding a signal for its changing, to represent toggling lights.
    Cleaned up a little bit of code in where new variables were defined before redefinitions.

This is all atomization to reduce changes in #52413
None of this affect gameplay at all, it's all code cleaning and refactoring.

There's more colors to standardize, a search for color = will find lots of targets, and I see little need to have both the LIGHT_COLOR and COLOR patterns, but I don't want to make this PR bigger than it already is.

* Color standardization, vars moved, and signals

Co-authored-by: Rohesie <rohesie@gmail.com>
This commit is contained in:
SkyratBot
2020-08-04 12:20:31 +02:00
committed by GitHub
co-authored by Rohesie
parent 2a0db9c922
commit 5fd8cb072e
78 changed files with 355 additions and 281 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/ruins/spaceruin_code/caravanambush.dm
+4 -4
View File
@@ -78,7 +78,7 @@
desc = "Used to control the Pirate Cutter."
icon_screen = "syndishuttle"
icon_keyboard = "syndie_key"
light_color = LIGHT_COLOR_RED
light_color = COLOR_SOFT_RED
circuit = /obj/item/circuitboard/computer/caravan/pirate
shuttleId = "caravanpirate"
possible_destinations = "caravanpirate_custom;caravanpirate_ambush"
@@ -101,7 +101,7 @@
desc = "Used to control the Syndicate Fighter."
icon_screen = "syndishuttle"
icon_keyboard = "syndie_key"
light_color = LIGHT_COLOR_RED
light_color = COLOR_SOFT_RED
req_access = list(ACCESS_SYNDICATE)
circuit = /obj/item/circuitboard/computer/caravan/syndicate1
shuttleId = "caravansyndicate1"
@@ -126,7 +126,7 @@
icon_screen = "syndishuttle"
icon_keyboard = "syndie_key"
req_access = list(ACCESS_SYNDICATE)
light_color = LIGHT_COLOR_RED
light_color = COLOR_SOFT_RED
circuit = /obj/item/circuitboard/computer/caravan/syndicate2
shuttleId = "caravansyndicate2"
possible_destinations = "caravansyndicate2_custom;caravansyndicate2_ambush;caravansyndicate1_listeningpost"
@@ -150,7 +150,7 @@
icon_screen = "syndishuttle"
icon_keyboard = "syndie_key"
req_access = list(ACCESS_SYNDICATE)
light_color = LIGHT_COLOR_RED
light_color = COLOR_SOFT_RED
circuit = /obj/item/circuitboard/computer/caravan/syndicate3
shuttleId = "caravansyndicate3"
possible_destinations = "caravansyndicate3_custom;caravansyndicate3_ambush;caravansyndicate3_listeningpost"