From 604a331213c1aa4979aac5bc97f1d3904c19ac0d Mon Sep 17 00:00:00 2001 From: Fikou Date: Thu, 19 Mar 2020 22:17:42 +0100 Subject: [PATCH] Apply suggestions from code review thanks rohesie Co-Authored-By: Rohesie --- code/game/mecha/mecha.dm | 2 +- code/game/mecha/working/clarke.dm | 10 +++++----- code/game/mecha/working/ripley.dm | 3 ++- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/code/game/mecha/mecha.dm b/code/game/mecha/mecha.dm index 1f66583d5ae..8141cbb576d 100644 --- a/code/game/mecha/mecha.dm +++ b/code/game/mecha/mecha.dm @@ -3,7 +3,7 @@ desc = "Exosuit" icon = 'icons/mecha/mecha.dmi' density = TRUE //Dense. To raise the heat. - opacity = 1 //opaque. Menacing. + opacity = TRUE //opaque. Menacing. move_force = MOVE_FORCE_VERY_STRONG move_resist = MOVE_FORCE_EXTREMELY_STRONG resistance_flags = FIRE_PROOF | ACID_PROOF diff --git a/code/game/mecha/working/clarke.dm b/code/game/mecha/working/clarke.dm index fea822fbe02..c76668342f5 100644 --- a/code/game/mecha/working/clarke.dm +++ b/code/game/mecha/working/clarke.dm @@ -21,7 +21,7 @@ /obj/mecha/working/clarke/Initialize() . = ..() box = new /obj/structure/ore_box(src) - var/obj/item/mecha_parts/mecha_equipment/ME = new /obj/item/mecha_parts/mecha_equipment/orebox_manager(src) + var/obj/item/mecha_parts/mecha_equipment/orebox_manager/ME = new(src) ME.attach(src) /obj/mecha/working/clarke/Destroy() @@ -39,7 +39,7 @@ var/mob/living/L = occupant var/datum/atom_hud/hud = GLOB.huds[DATA_HUD_DIAGNOSTIC_ADVANCED] hud.remove_hud_from(L) - ..() + return ..() /obj/mecha/working/clarke/mmi_moved_inside(obj/item/mmi/M, mob/user) . = ..() @@ -68,13 +68,13 @@ /obj/item/mecha_parts/mecha_equipment/orebox_manager/detach() hostmech = null //just in case - . = ..() + return ..() /obj/item/mecha_parts/mecha_equipment/orebox_manager/Topic(href,href_list) - ..() + . = ..() if(!hostmech || !hostmech.box) return hostmech.box.dump_box_contents() /obj/item/mecha_parts/mecha_equipment/orebox_manager/get_equip_info() - return "[..()] [hostmech?.box?"Unload Cargo":"Error"]" + return "[..()] [hostmech?.box ? "Unload Cargo" : "Error"]" diff --git a/code/game/mecha/working/ripley.dm b/code/game/mecha/working/ripley.dm index bede1e3bf7a..f23fb7d0a94 100644 --- a/code/game/mecha/working/ripley.dm +++ b/code/game/mecha/working/ripley.dm @@ -196,7 +196,8 @@ if(lavaland_equipment_pressure_check(T)) step_in = fast_pressure_step_in for(var/obj/item/mecha_parts/mecha_equipment/drill/drill in equipment) - drill.equip_cooldown = initial(drill.equip_cooldown)/2 + drill.equip_cooldown = initial(drill.equip_cooldown) * 0.5 + else step_in = slow_pressure_step_in for(var/obj/item/mecha_parts/mecha_equipment/drill/drill in equipment)