From 6603dbbdff2a50360c0329d007ccc598eb80468f Mon Sep 17 00:00:00 2001 From: SkyratBot <59378654+SkyratBot@users.noreply.github.com> Date: Sun, 19 Nov 2023 20:36:44 +0100 Subject: [PATCH] [MIRROR] Fixes an issue with un-hidden (alien, syndie etc.) nodes not being researchable. [MDB IGNORE] (#25122) * Fixes an issue with un-hidden (alien, syndie etc.) nodes not being researchable. (#79763) ## About The Pull Request Recently, I've been trying to unlock the ayy node, but couldn't even after disassembling an alien tool. Looked into the variables viewer and saw the node id wasn't set in the `available_nodes` list. It seems there was no update after it being unhidden. ## Why It's Good For The Game Fixing an issue with the destructive analyzer, maybe from the new UI refactor, but I couldn't bother to git blame it. ## Changelog :cl: fix: Fixed an issue with un-hidden (alien, syndie etc.) nodes not being researchable. /:cl: * Fixes an issue with un-hidden (alien, syndie etc.) nodes not being researchable. --------- Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com> --- code/modules/research/destructive_analyzer.dm | 4 ++-- code/modules/research/techweb/_techweb.dm | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/code/modules/research/destructive_analyzer.dm b/code/modules/research/destructive_analyzer.dm index 03a6d9934f5..6a6ca353d5a 100644 --- a/code/modules/research/destructive_analyzer.dm +++ b/code/modules/research/destructive_analyzer.dm @@ -179,10 +179,10 @@ var/datum/techweb_node/node_to_discover = SSresearch.techweb_node_by_id(id) if(!istype(node_to_discover)) return FALSE - SSblackbox.record_feedback("nested tally", "item_deconstructed", 1, list("[node_to_discover.id]", "[loaded_item.type]")) if(!destroy_item()) return FALSE - stored_research.unhide_node(SSresearch.techweb_node_by_id(node_to_discover.id)) + SSblackbox.record_feedback("nested tally", "item_deconstructed", 1, list("[node_to_discover.id]", "[loaded_item.type]")) + stored_research.unhide_node(node_to_discover) return TRUE #undef DESTRUCTIVE_ANALYZER_DESTROY_POINTS diff --git a/code/modules/research/techweb/_techweb.dm b/code/modules/research/techweb/_techweb.dm index 8aeb63a9f8a..5bda3865df2 100644 --- a/code/modules/research/techweb/_techweb.dm +++ b/code/modules/research/techweb/_techweb.dm @@ -409,6 +409,8 @@ if(!istype(node)) return FALSE hidden_nodes -= node.id + ///Make it available if the prereq ids are already researched + update_node_status(node) return TRUE /datum/techweb/proc/update_tiers(datum/techweb_node/base)