Refactors faction lists to use getters and setters and be cached (#94490)

code/modules/mod/mod_core.dm

@@ -487,7 +487,7 @@
 			spawn_types = list(spawned_mob_type), \
 			spawn_time = 5 SECONDS, \
 			max_spawned = 3, \
-			faction = mod.wearer.faction, \
+			faction = mod.wearer.get_faction(), \
 		)
 		RegisterSignal(mob_spawner, COMSIG_SPAWNER_SPAWNED, PROC_REF(new_mob))
 		RegisterSignal(mod.wearer, COMSIG_MOVABLE_MOVED, PROC_REF(spread_flowers))

code/modules/mod/modules/modules_ninja.dm

@@ -491,7 +491,7 @@
 
 //BORG, Ninja objective converts a borg to a syndicate version
 /mob/living/silicon/robot/ninjadrain_act(mob/living/carbon/human/ninja, obj/item/mod/module/hacker/hacking_module)
-	if(!ninja || !hacking_module || (ROLE_NINJA in faction))
+	if(!ninja || !hacking_module || (has_faction(ROLE_NINJA)))
 		return NONE
 
 	to_chat(src, span_danger("Warni-***BZZZZZZZZZRT*** UPLOADING SPYDERPATCHER VERSION 9.5.2..."))