cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-26 14:39:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

Converts SFX keys into DEFINES (#65146)

Browse Source 
About The Pull Request

Simply converts all instances of soundkeys that use get_sfx from strings into defines.

E.g. "sparks" is now SFX_SPARKS
Why It's Good For The Game

It makes life a lot easier when you're looking for a sound effect. You just type SFX_ and you get suggestions in VSC. Plus, it looks better.

image
Changelog

Not player facing.
This commit is contained in:
Gandalf
2022-03-11 10:09:18 +13:00
committed by GitHub
parent 76ff3a5f8e
commit 684eab3d31
143 changed files with 265 additions and 236 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/modular_computers/file_system/programs/card.dm
+6 -6
View File
@@ -183,7 +183,7 @@
if(!new_name)
target_id_card.registered_name = null
playsound(computer, "terminal_type", 50, FALSE)
playsound(computer, SFX_TERMINAL_TYPE, 50, FALSE)
target_id_card.update_label()
// We had a name before and now we have no name, so this will unassign the card and we update the icon.
if(old_name)
@@ -198,7 +198,7 @@
return TRUE
target_id_card.registered_name = new_name
playsound(computer, "terminal_type", 50, FALSE)
playsound(computer, SFX_TERMINAL_TYPE, 50, FALSE)
target_id_card.update_label()
// Card wasn't assigned before and now it is, so update the icon accordingly.
if(!old_name)
@@ -215,7 +215,7 @@
return TRUE
target_id_card.registered_age = new_age
playsound(computer, "terminal_type", 50, FALSE)
playsound(computer, SFX_TERMINAL_TYPE, 50, FALSE)
return TRUE
// Change assignment
if("PRG_assign")
@@ -223,14 +223,14 @@
return TRUE
var/new_asignment = sanitize(params["assignment"])
target_id_card.assignment = new_asignment
playsound(computer, "terminal_type", 50, FALSE)
playsound(computer, SFX_TERMINAL_TYPE, 50, FALSE)
target_id_card.update_label()
return TRUE
// Add/remove access.
if("PRG_access")
if(!computer || !authenticated_card || !target_id_card)
return TRUE
playsound(computer, "terminal_type", 50, FALSE)
playsound(computer, SFX_TERMINAL_TYPE, 50, FALSE)
var/access_type = params["access_target"]
var/try_wildcard = params["access_wildcard"]
if(!(access_type in valid_access))
@@ -256,7 +256,7 @@
if(!computer || !authenticated_card || !target_id_card)
return TRUE
playsound(computer, "terminal_type", 50, FALSE)
playsound(computer, SFX_TERMINAL_TYPE, 50, FALSE)
var/template_name = params["name"]
if(!template_name)
code/modules/modular_computers/file_system/programs/secureye.dm
+1 -1
View File
@@ -124,7 +124,7 @@
var/list/cameras = get_available_cameras()
var/obj/machinery/camera/selected_camera = cameras[c_tag]
camera_ref = WEAKREF(selected_camera)
playsound(src, get_sfx("terminal_type"), 25, FALSE)
playsound(src, get_sfx(SFX_TERMINAL_TYPE), 25, FALSE)
if(!selected_camera)
return TRUE