cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-30 00:29:02 +01:00
Code Issues Packages Projects Releases Wiki Activity

Converts SFX keys into DEFINES (#65146)

Browse Source 
About The Pull Request

Simply converts all instances of soundkeys that use get_sfx from strings into defines.

E.g. "sparks" is now SFX_SPARKS
Why It's Good For The Game

It makes life a lot easier when you're looking for a sound effect. You just type SFX_ and you get suggestions in VSC. Plus, it looks better.

image
Changelog

Not player facing.
This commit is contained in:
Gandalf
2022-03-11 10:09:18 +13:00
committed by GitHub
parent 76ff3a5f8e
commit 684eab3d31
143 changed files with 265 additions and 236 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/wiremod/shell/controller.dm
+3 -3
View File
@@ -59,7 +59,7 @@
if(!user.Adjacent(source))
return
source.balloon_alert(user, "clicked primary button")
playsound(source, get_sfx("terminal_type"), 25, FALSE)
playsound(source, get_sfx(SFX_TERMINAL_TYPE), 25, FALSE)
entity.set_output(user)
signal.set_output(COMPONENT_SIGNAL)
@@ -71,7 +71,7 @@
if(!user.Adjacent(source))
return
source.balloon_alert(user, "clicked alternate button")
playsound(source, get_sfx("terminal_type"), 25, FALSE)
playsound(source, get_sfx(SFX_TERMINAL_TYPE), 25, FALSE)
entity.set_output(user)
alt.set_output(COMPONENT_SIGNAL)
@@ -83,6 +83,6 @@
if(!user.Adjacent(source))
return
source.balloon_alert(user, "clicked extra button")
playsound(source, get_sfx("terminal_type"), 25, FALSE)
playsound(source, get_sfx(SFX_TERMINAL_TYPE), 25, FALSE)
entity.set_output(user)
right.set_output(COMPONENT_SIGNAL)