cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-25 14:08:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

[MIRROR] [s] Patch a server crashing exploit (#7794)

Browse Source 
* [s] Patch a server crashing exploit (#61057)

if you create a bunch of signallers then spam the send signal button you can grind the server to a halt at low numbers and crash it at high numbers of signallers

This is an imperfect fix as a proper fix would refactor signal datums to use a subsystem but I dont feel like rewriting all of signal code thank you very much

Co-authored-by: Zephyr <12817816+ZephyrTFA@ users.noreply.github.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>

* [s] Patch a server crashing exploit

Co-authored-by: TiviPlus <57223640+TiviPlus@users.noreply.github.com>
Co-authored-by: Zephyr <12817816+ZephyrTFA@ users.noreply.github.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
This commit is contained in:
SkyratBot
2021-08-26 22:49:14 +01:00
committed by GitHub
co-authored by Zephyr Mothblocks TiviPlus
parent 71c62fed86
commit 68db67c4eb
4 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/assembly/signaler.dm
+4
View File
@@ -91,6 +91,10 @@
switch(action)
if("signal")
if(TIMER_COOLDOWN_CHECK(src, COOLDOWN_SIGNALLER_SEND))
to_chat(usr, span_warning("[src] is still recharging..."))
return
TIMER_COOLDOWN_START(src, COOLDOWN_SIGNALLER_SEND, 1 SECONDS)
INVOKE_ASYNC(src, .proc/signal)
. = TRUE
if("freq")