cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-07-16 10:35:41 +01:00
Code Issues Packages Projects Releases Wiki Activity

[MIRROR] Converts ore_mined talley into only recording typepaths. (#26957)

Browse Source 
* Converts ore_mined talley into only recording typepaths. (#82098)

## About The Pull Request

This Pull request makes it so that the blackbox `ore_mined` talley will
now only record the mineral stack's typepath as opposed to a 50/50 mix
of names and typepaths.

## Why It's Good For The Game

Fixes #82042. Logging should be as descriptive as possible while also
avoiding the possibility for misunderstanding, so using the typepath for
logging on the blackbox is preferred.

## Changelog

🆑
code: Mineral logging now collects ore names more cleanly.
/🆑

* Converts ore_mined talley into only recording typepaths.

---------

Co-authored-by: ArcaneMusic <41715314+ArcaneMusic@users.noreply.github.com>
This commit is contained in:
SkyratBot
2024-03-20 11:36:58 +01:00
committed by GitHub
parent 41392561a7
commit 6b0c26bd9c
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/mining/boulder_processing/boulder.dm
+1 -1
View File
@@ -163,7 +163,7 @@
stack_trace("boulder found containing material type [picked.type] with no set ore_type")
continue
cracked_ore = new cracked_ore_type (drop_location(), quantity)
SSblackbox.record_feedback("tally", "ore_mined", quantity, cracked_ore)
SSblackbox.record_feedback("tally", "ore_mined", quantity, cracked_ore.type)
///Moves boulder contents to the drop location, and then deletes the boulder.
/obj/item/boulder/proc/break_apart()