cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-23 13:10:02 +01:00
Code Issues Packages Projects Releases Wiki Activity

[MIRROR] Fixes the orbiter component spamming RegisterSignal overrides. (#934)

Browse Source 
* Fixes the orbiter component spamming RegisterSignal overrides. (#53891)

Orbiter component keeps Registering the same redundant signal every time a player decides to orbit an atom that already has people orbiting it.

One Register call to one Unregister call and we'll clean up a fuckton of stack_traces about overriding signals from the runtime logs.

* Fixes the orbiter component spamming RegisterSignal overrides.

Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
This commit is contained in:
SkyratBot
2020-09-23 14:55:08 +02:00
committed by GitHub
co-authored by Timberpoes
parent f3d2497aba
commit 6c57007cd1
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/datums/components/orbiter.dm
+2 -1
View File
@@ -24,6 +24,8 @@
if(ismovable(target))
tracker = new(target, CALLBACK(src, .proc/move_react))
RegisterSignal(parent, COMSIG_MOVABLE_UPDATE_GLIDE_SIZE, .proc/orbiter_glide_size_update)
/datum/component/orbiter/UnregisterFromParent()
UnregisterSignal(parent, COMSIG_MOVABLE_UPDATE_GLIDE_SIZE)
var/atom/target = parent
@@ -41,7 +43,6 @@
/datum/component/orbiter/InheritComponent(datum/component/orbiter/newcomp, original, atom/movable/orbiter, radius, clockwise, rotation_speed, rotation_segments, pre_rotation)
if(!newcomp)
RegisterSignal(parent, COMSIG_MOVABLE_UPDATE_GLIDE_SIZE, .proc/orbiter_glide_size_update)
begin_orbit(arglist(args.Copy(3)))
return
// The following only happens on component transfers