From 6dd4839ef321aa0a997549d1ae07fe7ccbba59ed Mon Sep 17 00:00:00 2001 From: carshalash Date: Sun, 18 Dec 2022 15:41:13 +1000 Subject: [PATCH] Gatfruit will no longer drop from ice portals. (#72048) ## About The Pull Request For some god-forsaken reason, somebody decided that ice portals should be able to drop one of the most disruptive items in the game. This PR amends this by removing it from the drop pool. ## Why It's Good For The Game In 2013 gatfruit was introduced in the following PR #2000 . This was almost a decade ago at this point, repeatedly through the PR the creator states his belief that this item should only ever be obtainable through admin intervention due to its ridiculous capabilities. At the time everyone in the PR agreed it was a reasonable item to add **as it was unobtainable without admin intervention**. Over the years, it has crept its way to become more prevalent and openly obtainable, the most offensive of these options is the ice moon portal. As is, there is a 1 in 28 chance of obtaining the seeds, this sounds pretty inoffensive right? That's just 3.44% probability. Now, let us search the instances of the portal that spawns this. ![image](https://user-images.githubusercontent.com/16896032/208220173-bbefe604-0885-44a5-9add-b5f0c62067cc.png) That is a big number, a lot of chances to get that seed packet and other gamer looters. Now, let's take a look at the probability of being able to get these seeds, assuming you wipe out all of the portals. ![image](https://user-images.githubusercontent.com/16896032/208220460-3f59a2ac-d936-4f3a-aa14-9c637af6a9d7.png) 92.8% chance to be able to get these seeds each shift if you focus entirely on gaming the portals. That's a pretty insane probability of being able to obtain the gatfruit seeds. While I dislike people who sprint to the seed vault, there is at least the possibility of a pod person telling them to fuck off when they demand their _free_ gamer seed. There is also the fact that the ruin isn't a guaranteed spawn every shift. ## Changelog :cl: balance: Gatfruit seeds will no longer drop from ice portals. /:cl: --- code/game/objects/structures/icemoon/cave_entrance.dm | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/code/game/objects/structures/icemoon/cave_entrance.dm b/code/game/objects/structures/icemoon/cave_entrance.dm index d72199af0d6..8261c7a3bc7 100644 --- a/code/game/objects/structures/icemoon/cave_entrance.dm +++ b/code/game/objects/structures/icemoon/cave_entrance.dm @@ -134,7 +134,7 @@ GLOBAL_LIST_INIT(ore_probability, list( */ /obj/effect/collapsing_demonic_portal/proc/drop_loot() visible_message(span_warning("Something slips out of [src]!")) - var/loot = rand(1, 28) + var/loot = rand(1, 27) switch(loot) if(1) new /obj/item/clothing/suit/hooded/cultrobes/hardened(loc) @@ -169,7 +169,7 @@ GLOBAL_LIST_INIT(ore_probability, list( new /obj/item/ship_in_a_bottle(loc) new /obj/item/oar(loc) if(16) - new /obj/item/seeds/gatfruit(loc) + new /mob/living/simple_animal/hostile/megafauna/blood_drunk_miner/doom(loc) if(17) new /obj/item/reagent_containers/cup/glass/drinkingglass/filled/nuka_cola(loc) if(18) @@ -192,5 +192,3 @@ GLOBAL_LIST_INIT(ore_probability, list( new /obj/item/clothing/shoes/winterboots/ice_boots(loc) if(27) new /obj/item/book/granter/action/spell/sacredflame(loc) - if(28) - new /mob/living/simple_animal/hostile/megafauna/blood_drunk_miner/doom(loc)