cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2025-12-09 16:05:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

[MIRROR] OpenDream TypeMaker Prep (#26762)

Browse Source 
* OpenDream TypeMaker Prep (#81830)

## About The Pull Request

OpenDream is adding support for proc and var typechecking using `as` in
https://github.com/OpenDreamProject/OpenDream/pull/1705

BYOND silently ignores most uses of `as`, but OpenDream can leverage it
for static typing.

E.g. the following code will error in OpenDream while doing nothing in
BYOND:
```
/datum/proc/meep() as text
    return "meep"

/datum/foobar/meep()
    return 5
```
`Warning OD2701 at code.dm:29:8: /datum/foobar/meep(): Invalid return
type "num", expected "text"`

Pragmas allow these type emissions to be warnings, errors, or suppressed
entirely.

This PR modifies some existing uses of `as` in TG to prevent
`ImplicitNullType` warnings (which is when a var with a null value
doesn't explicitly have the `|null` type specified). This specific
pragma is a bit opinionated so it could simply be disabled, but since
this has no impact on BYOND behavior I don't see a reason not to fix
these examples anyways.

## Why It's Good For The Game

Typechecking.

## Changelog

no cl no fun

* OpenDream TypeMaker Prep

---------

Co-authored-by: ike709 <ike709@users.noreply.github.com>
This commit is contained in:
SkyratBot
2024-03-07 04:15:12 +01:00
committed by GitHub
parent 041fea279f
commit 6e360e1234
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
code/__DEFINES/procpath.dm
View File

@@ -15,12 +15,12 @@
// below, their accesses are optimized away. // below, their accesses are optimized away.
/// A text string of the verb's name. /// A text string of the verb's name.
var/name as text var/name = null as text|null
/// The verb's help text or description. /// The verb's help text or description.
var/desc as text var/desc = null as text|null
/// The category or tab the verb will appear in. /// The category or tab the verb will appear in.
var/category as text var/category = null as text|null
/// Only clients/mobs with `see_invisibility` higher can use the verb. /// Only clients/mobs with `see_invisibility` higher can use the verb.
var/invisibility as num var/invisibility = null as num|null
/// Whether or not the verb appears in statpanel and commandbar when you press space /// Whether or not the verb appears in statpanel and commandbar when you press space
var/hidden as num var/hidden = null as num|null

2
code/modules/mob/living/living.dm
View File

@@ -524,7 +524,7 @@
log_message("points at [pointing_at]", LOG_EMOTE) log_message("points at [pointing_at]", LOG_EMOTE)
visible_message("<span class='infoplain'>[span_name("[src]")] points at [pointing_at].</span>", span_notice("You point at [pointing_at].")) visible_message("<span class='infoplain'>[span_name("[src]")] points at [pointing_at].</span>", span_notice("You point at [pointing_at]."))
/mob/living/verb/succumb(whispered as null) /mob/living/verb/succumb(whispered as num|null)
set hidden = TRUE set hidden = TRUE
if (!CAN_SUCCUMB(src)) if (!CAN_SUCCUMB(src))
if(HAS_TRAIT(src, TRAIT_SUCCUMB_OVERRIDE)) if(HAS_TRAIT(src, TRAIT_SUCCUMB_OVERRIDE))

2
code/modules/mob/mob_transformation_simple.dm
View File

@@ -2,7 +2,7 @@
//This proc is the most basic of the procs. All it does is make a new mob on the same tile and transfer over a few variables. //This proc is the most basic of the procs. All it does is make a new mob on the same tile and transfer over a few variables.
//Returns the new mob //Returns the new mob
//Note that this proc does NOT do MMI related stuff! //Note that this proc does NOT do MMI related stuff!
/mob/proc/change_mob_type(new_type = null, turf/location = null, new_name = null as text, delete_old_mob = FALSE) /mob/proc/change_mob_type(new_type = null, turf/location = null, new_name = null as text|null, delete_old_mob = FALSE)
if(isnewplayer(src)) if(isnewplayer(src))
to_chat(usr, span_danger("Cannot convert players who have not entered yet.")) to_chat(usr, span_danger("Cannot convert players who have not entered yet."))