Gives non-standard nullrods the rest of the features common to regular null rods (#94980)

## About The Pull Request

Non-standard null-rods (the skateboard, bow, revolver, carpsie plush,
and eswords) did not receive all the common characteristics of regular
null rods in #93394. In particular, they were not given the
`UNIQUE_RENAME` obj flag, and they did not receive the ability to track
how many cultists they've crit/killed and be turned into cult weapons
when sacrificed. This PR corrects that by extracting the cult kill
tracking behavior to a component, while doing the following refactors to
ensure complete compatibility:

- Skateboard items now move themselves into the skateboard vehicle they
spawn on use, instead of deleting themselves. This was necessary for the
holy board to keep its custom name/desc and cultist kill count.
- Guns (which the bow technically is) will track cultists killed/crit
with bullets fired from them by a mob with a holy role.
- A signal can now be used for an item to provide an arbitrary response
when an offer rune underneath it is activated.

## Why It's Good For The Game

I just wanted the holy eswords to be renameable for chaplains to provide
plausible deniability for the possession of actual eswords, but after I
discovered this consistency issue, and felt the need to fix it.

## Changelog

🆑
fix: The holy energy swords and the carp-sie plushie can once again be
renamed
fix: The holy energy swords and the carp-sie plushie can once again be
sacrificed by cultists to spawn different weapons based on how many
unique cultists the chaplain has crit or killed with them
qol: The holy skateboard can be renamed like other null rod variants can
fix: Unusual null rod variants like the holy skateboard and bow can now
be sacrificed by cultists to spawn different weapons based on how many
unique cultists the chaplain has crit or killed with them. The bow and
the burdened chaplain's revolver, in particular, also count cultists
crit or killed by arrows/bullets fired from them by the chaplain.
/🆑
This commit is contained in:
Y0SH1M4S73R
2026-02-03 22:23:20 -05:00
committed by GitHub
parent f58b8511f0
commit 6f37db300b
12 changed files with 138 additions and 88 deletions
+4 -3
View File
@@ -15,9 +15,9 @@
var/board_item_type = /obj/vehicle/ridden/scooter/skateboard
/obj/item/melee/skateboard/attack_self(mob/user)
var/obj/vehicle/ridden/scooter/skateboard/S = new board_item_type(get_turf(user))//this probably has fucky interactions with telekinesis but for the record it wasn't my fault
S.buckle_mob(user)
qdel(src)
var/obj/vehicle/ridden/scooter/skateboard/board = new board_item_type(get_turf(user), src)//this probably has fucky interactions with telekinesis but for the record it wasn't my fault
board.buckle_mob(user)
forceMove(board)
/obj/item/melee/skateboard/improvised
name = "improvised skateboard"
@@ -55,6 +55,7 @@
force = 18
throwforce = 6
w_class = WEIGHT_CLASS_NORMAL
obj_flags = parent_type::obj_flags | UNIQUE_RENAME
attack_verb_continuous = list("bashes", "crashes", "grinds", "skates")
attack_verb_simple = list("bash", "crash", "grind", "skate")
board_item_type = /obj/vehicle/ridden/scooter/skateboard/hoverboard/holyboarded
@@ -556,6 +556,7 @@
armour_penetration = 0
wound_bonus = -10
demolition_mod = 1
obj_flags = parent_type::obj_flags | UNIQUE_RENAME
sword_color_icon = "blue"
light_color = LIGHT_COLOR_LIGHT_CYAN
active_force = 18