cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-24 05:30:05 +01:00
Code Issues Packages Projects Releases Wiki Activity

Refactors mothweek check (#68280)

Browse Source 
* Refactors mothweek check

Mothweek HAS SIDE EFFECTS
Checking it on a day that causes a week offset will currently cause that
week offset to persist
That's dumb.

Also it's not very expansive, only covers a slim set of possibilities.

Instead, lets build something to generate all passing days over a period
of time, maybe 3 months out of 2 years.
Then we'll crosscheck that against some predecided "ok" dates

If either list disagrees with each other, we'll fail. That way we can't
miss an edgecase. or have issues with side effects

I like this pattern.
This commit is contained in:
LemonInTheDark
2022-07-10 15:44:58 -07:00
committed by GitHub
parent 9f3035389b
commit 6f533ae620
3 changed files with 59 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/unit_tests/holidays.dm
+17 -5
View File
@@ -29,8 +29,20 @@
TEST_ASSERT(new_year.shouldCelebrate(2, JANUARY, 1983, SUNDAY), "January 2, 1983 was not New Year.")
/datum/unit_test/moth_week_2020/Run()
var/datum/holiday/nth_week/moth/moth = new
TEST_ASSERT(moth.shouldCelebrate(18, JULY, 2020, SATURDAY), "July 18, 2020 was not Moth Week.")
TEST_ASSERT(moth.shouldCelebrate(20, JULY, 2020, MONDAY), "July 20, 2020 was not Moth Week.")
TEST_ASSERT(moth.shouldCelebrate(24, JULY, 2020, FRIDAY), "July 24, 2020 was not Moth Week.")
TEST_ASSERT(moth.shouldCelebrate(26, JULY, 2020, SUNDAY), "July 26, 2020 was not Moth Week.")
// We expect 2 year's worth of moth week, falling on the last full week of july
// We test ahead and behind just in case something's fucked
// Both lists are in the form yyyy/m/d
var/list/produced_moth_days = poll_holiday(/datum/holiday/nth_week/moth, 6, 8, 2020, 2021, 31)
var/list/predicted_moth_days = list()
for(var/day in 18 to 26) // Last full week of July 2020
predicted_moth_days += "2020/7/[day]"
for(var/day in 17 to 25) // Last full week of July 2021
predicted_moth_days += "2021/7/[day]"
var/list/unexpected_moths = produced_moth_days - predicted_moth_days
for(var/date in unexpected_moths)
TEST_FAIL("[date] was improperly Moth Week")
var/list/missing_moths = predicted_moth_days - produced_moth_days
for(var/date in missing_moths)
TEST_FAIL("[date] was not Moth Week")