Small playsound audit, particularly involving portal sounds (#83893)

## About The Pull Request

I was looking at sounds (as you do) and I noticed this


![image](https://github.com/tgstation/tgstation/assets/51863163/25b298ca-31ac-48a0-9f86-c65a8becd532)

These sounds don't exist

We have `portal_open_1`, not `portal_open1`. 
This wasn't caught on compile because they used `""` and not `''`.

So I went through and audited a bunch of playsound uses that don't use
`''`. Only one error, fortunately

Likewise there was a ton of places running `get_sfx` pointlessly
(because `playsound` does it for you) so I clened that up.

However while auditing the portal stuff I noticed a few oddities, so I
cleaned it up a bit.

Also also I added the portal sounds to the wormholes event and gave it a
free ™️ optimization because it was an in-world loop

## Changelog

🆑 Melbert
sound: Portals made by portal guns now make sounds as expected
sound: Wormholes from the wormhole event now make sounds when formed
/🆑
This commit is contained in:
MrMelbert
2024-06-13 23:47:37 -06:00
committed by GitHub
parent 81b75f724b
commit 6fea9d999d
38 changed files with 97 additions and 68 deletions
+1 -1
View File
@@ -43,6 +43,6 @@
/obj/item/circuit_component/bot/proc/on_attack_hand(atom/source, mob/user)
SIGNAL_HANDLER
source.balloon_alert(user, "pushed button")
playsound(source, get_sfx(SFX_TERMINAL_TYPE), 25, FALSE)
playsound(source, SFX_TERMINAL_TYPE, 25, FALSE)
entity.set_output(user)
signal.set_output(COMPONENT_SIGNAL)
+1 -1
View File
@@ -45,6 +45,6 @@
/obj/item/circuit_component/compact_remote/proc/send_trigger(atom/source, mob/user)
SIGNAL_HANDLER
source.balloon_alert(user, "clicked primary button")
playsound(source, get_sfx(SFX_TERMINAL_TYPE), 25, FALSE)
playsound(source, SFX_TERMINAL_TYPE, 25, FALSE)
entity.set_output(user)
signal.set_output(COMPONENT_SIGNAL)
+1 -1
View File
@@ -53,7 +53,7 @@
/obj/item/circuit_component/controller/proc/handle_trigger(atom/source, user, port_name, datum/port/output/port_signal)
source.balloon_alert(user, "clicked [port_name] button")
playsound(source, get_sfx(SFX_TERMINAL_TYPE), 25, FALSE)
playsound(source, SFX_TERMINAL_TYPE, 25, FALSE)
entity.set_output(user)
port_signal.set_output(COMPONENT_SIGNAL)
+1 -1
View File
@@ -68,7 +68,7 @@
/obj/item/circuit_component/wiremod_gun/proc/handle_shot(atom/source, mob/firer, atom/target, angle)
SIGNAL_HANDLER
playsound(source, get_sfx(SFX_TERMINAL_TYPE), 25, FALSE)
playsound(source, SFX_TERMINAL_TYPE, 25, FALSE)
shooter.set_output(firer)
shot.set_output(target)
signal.set_output(COMPONENT_SIGNAL)