cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2025-12-12 18:51:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

[MIRROR] kills 4 object definitions that are inside of proc arguments (#7987)

Browse Source 
* kills 4 object definitions that are inside of proc arguments (#61152)

thanks to putnam for reporting this in coderbus
/obj/machinery/smartfridge/drying_rack/load(/obj/item/dried_object)
looks pretty harmless right? youd think that this would make a proc argument called dried_object of type /obj/item but no, this defines a new /obj/item class definition called dried_object with zero changes from /obj/item

you can use this to do weird things, like /obj/machinery/smartfridge/drying_rack/load(/obj/item/var/dried_object = 3)
creates a new var on /obj/item called dried_object and is very cursed
gets rid of 4 of these abominations, they dont seem to have caused any bugs except for maybe behavior that relies on typesof(/some/path)

* kills 4 object definitions that are inside of proc arguments

Co-authored-by: Kylerace <kylerlumpkin1@gmail.com>
This commit is contained in:
SkyratBot
2021-09-05 23:54:54 +02:00
committed by GitHub
parent 1cbfe28077
commit 701da750f2
4 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
code/datums/materials/_material.dm
View File

@@ -95,7 +95,7 @@ Simple datum which is instanced once per type and is used for every object of sa
source.mat_update_desc(src) source.mat_update_desc(src)
///This proc is called when a material updates an object's description ///This proc is called when a material updates an object's description
/atom/proc/mat_update_desc(/datum/material/mat) /atom/proc/mat_update_desc(datum/material/mat)
return return
///This proc is called when the material is added to an object specifically. ///This proc is called when the material is added to an object specifically.

2
code/datums/quirks/negative.dm
View File

@@ -300,7 +300,7 @@
SEND_SIGNAL(quirk_holder, COMSIG_CLEAR_MOOD_EVENT, "nyctophobia") SEND_SIGNAL(quirk_holder, COMSIG_CLEAR_MOOD_EVENT, "nyctophobia")
/// Called when the quirk holder moves. Updates the quirk holder's mood. /// Called when the quirk holder moves. Updates the quirk holder's mood.
/datum/quirk/nyctophobia/proc/on_holder_moved(/mob/living/source, atom/old_loc, dir, forced) /datum/quirk/nyctophobia/proc/on_holder_moved(mob/living/source, atom/old_loc, dir, forced)
SIGNAL_HANDLER SIGNAL_HANDLER
if(quirk_holder.stat == DEAD) if(quirk_holder.stat == DEAD)

2
code/modules/food_and_drinks/kitchen_machinery/smartfridge.dm
View File

@@ -308,7 +308,7 @@
if(!powered()) if(!powered())
toggle_drying(TRUE) toggle_drying(TRUE)
/obj/machinery/smartfridge/drying_rack/load(/obj/item/dried_object) //For updating the filled overlay /obj/machinery/smartfridge/drying_rack/load(obj/item/dried_object) //For updating the filled overlay
. = ..() . = ..()
update_appearance() update_appearance()

2
code/modules/projectiles/guns/ballistic.dm
View File

@@ -593,7 +593,7 @@ GLOBAL_LIST_INIT(gun_saw_types, typecacheof(list(
update_appearance() update_appearance()
return TRUE return TRUE
/obj/item/gun/ballistic/proc/guncleaning(mob/user, /obj/item/A) /obj/item/gun/ballistic/proc/guncleaning(mob/user, obj/item/A)
if(misfire_probability == 0) if(misfire_probability == 0)
to_chat(user, span_notice("[src] seems to be already clean of fouling.")) to_chat(user, span_notice("[src] seems to be already clean of fouling."))
return return