cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-01-06 15:02:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use 1,1 instead of CENTER as relay_loc on 516 builds (#84035)

Browse Source 
## About The Pull Request

As of 516 build 1640, whenever render_source is used, the replacement
icon is now _ALWAYS_ anchored to the bottom left of the replaced icon.
This kinda breaks things that relied on the previous behavior of
everything being centered.

## Testing Evidence

![2024-06-16 (1718516096) ~
dreamseeker](https://github.com/tgstation/tgstation/assets/65794972/55e4ea1b-d15c-4e5a-9136-bb5ee3cce2d7)
![2024-06-16 (1718516157) ~
dreamseeker](https://github.com/tgstation/tgstation/assets/65794972/6d162959-44cb-404d-a755-535bdcc474f5)

## Why It's Good For The Game

Because having the game work is good.

## Changelog

None because 516 is still not a public beta yet.
This commit is contained in:
Lucy
2024-07-06 01:51:17 -04:00
committed by GitHub
parent a13d142bad
commit 726dc54d7f
2 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
code/_onclick/hud/rendering/plane_master_group.dm
View File

@@ -34,6 +34,14 @@
stack_trace("Hey brother, our key [key] is already in use by a plane master group on the passed in hud, belonging to [viewing_hud.mymob]. Ya fucked up, why are there dupes")
return
#if MIN_COMPILER_VERSION > 516
#warn Fully change default relay_loc to "1,1", rather than changing it based on client version
#endif
if(viewing_hud.mymob?.client?.byond_version > 515)
relay_loc = "1,1"
rebuild_plane_masters()
our_hud = viewing_hud
our_hud.master_groups[key] = src
show_hud()

7
code/_onclick/hud/rendering/render_plate.dm
View File

@@ -382,7 +382,7 @@
render_relay_planes = list(RENDER_PLANE_MASTER)
/**
* Plane master proc called in Initialize() that creates relay objects, and sets them uo as needed
* Plane master proc called in Initialize() that creates relay objects, and sets them up as needed
* Sets:
* * layer from plane to avoid z-fighting
* * planes to relay the render to
@@ -392,6 +392,9 @@
* Other vars such as alpha will automatically be applied with the render source
*/
/atom/movable/screen/plane_master/proc/generate_render_relays()
#if MIN_COMPILER_VERSION > 516
#warn Fully change default relay_loc to "1,1"
#endif
var/relay_loc = home?.relay_loc || "CENTER"
// If we're using a submap (say for a popup window) make sure we draw onto it
if(home?.map)
@@ -426,7 +429,7 @@
if(!length(relays) && !initial(render_target))
render_target = OFFSET_RENDER_TARGET(get_plane_master_render_base(name), offset)
if(!relay_loc)
relay_loc = "CENTER"
relay_loc = (show_to?.byond_version > 515) ? "1,1" : "CENTER"
// If we're using a submap (say for a popup window) make sure we draw onto it
if(home?.map)
relay_loc = "[home.map]:[relay_loc]"