cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-29 08:08:49 +01:00
Code Issues Packages Projects Releases Wiki Activity

Improve the naming of the element argument hash index selector (#71319)

Browse Source 
So confusing name
This commit is contained in:
oranges
2022-11-19 17:04:28 -08:00
committed by GitHub
parent 5b540c95c8
commit 74e43bc556
73 changed files with 80 additions and 77 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/unit_tests/bespoke_id.dm
+3 -3
View File
@@ -1,8 +1,8 @@
/datum/unit_test/bespoke_id/Run()
var/datum/element/base = /datum/element
var/base_index = initial(base.id_arg_index)
var/base_index = initial(base.argument_hash_start_idx)
for(var/i in subtypesof(/datum/element))
var/datum/element/faketype = i
if((initial(faketype.element_flags) & ELEMENT_BESPOKE) && initial(faketype.id_arg_index) == base_index)
TEST_FAIL("A bespoke element was not configured with a proper id_arg_index: [faketype]")
if((initial(faketype.element_flags) & ELEMENT_BESPOKE) && initial(faketype.argument_hash_start_idx) == base_index)
TEST_FAIL("A bespoke element was not configured with a proper argument_hash_start_idx: [faketype]")
code/modules/unit_tests/dcs_get_id_from_elements.dm
+3 -3
View File
@@ -38,9 +38,9 @@
/datum/unit_test/dcs_get_id_from_arguments/proc/get_id_from_arguments(list/arguments)
return SSdcs.GetIdFromArguments(list(/datum/element/dcs_get_id_from_arguments_mock_element) + arguments)
// Necessary because GetIdFromArguments uses id_arg_index from an element type
// Necessary because GetIdFromArguments uses argument_hash_start_idx from an element type
/datum/element/dcs_get_id_from_arguments_mock_element
id_arg_index = 2
argument_hash_start_idx = 2
/datum/element/dcs_get_id_from_arguments_mock_element2
id_arg_index = 2
argument_hash_start_idx = 2