mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-07-15 10:04:30 +01:00
Fixes SSWardrobe stealing a camera from the camera app when on a dummy, causing a harddel (#87903)
## About The Pull Request See name, if a dummy somehow gets hold of a PDA with the camera app installed (This just so happens to be a default PDA program in the case on Nova, Skyrat, and Bubber), and the delete_equipment proc is called, the camera inside the PDA gets sent to the wardrobe because of `/datum/outfit/job/assistant/gimmick/hall_monitor` having one, and then qdelled with the PDA, leaving a hanging ref This causes a harddel during tests that has caused me great pains to locate. Turns out a single example holodisk with the clown holds a magical key to trigger all this: a single PDA ## Why It's Good For The Game Fixes a harddel. There might be other similar ones hiding in the dark like cameras in other objects. ## Changelog 🆑 fix: Fixes SSWardrobe stealing a camera from the camera app when on a dummy, causing a harddel /🆑
This commit is contained in:
@@ -11,12 +11,18 @@
|
||||
circuit_comp_type = /obj/item/circuit_component/mod_program/camera
|
||||
|
||||
/// Camera built-into the tablet.
|
||||
var/obj/item/camera/internal_camera
|
||||
var/obj/item/camera/app/internal_camera
|
||||
/// Latest picture taken by the app.
|
||||
var/datum/picture/internal_picture
|
||||
/// How many pictures were taken already, used for the camera's TGUI photo display
|
||||
var/picture_number = 1
|
||||
|
||||
// Special type of camera for this exact usecase to prevent harddels
|
||||
/obj/item/camera/app
|
||||
name = "internal camera"
|
||||
desc = "Specialized internal camera protected from the hellish depths of SSWardrobe. \
|
||||
Yell at coders if you somehow manage to see this"
|
||||
|
||||
/datum/computer_file/program/maintenance/camera/on_install()
|
||||
. = ..()
|
||||
internal_camera = new(computer)
|
||||
|
||||
Reference in New Issue
Block a user