From 783dcf4b3b1cc72c2e32a36a4e2428a2427f42bb Mon Sep 17 00:00:00 2001 From: Lucy Date: Wed, 11 Jun 2025 12:37:30 -0400 Subject: [PATCH] Fix screentips on 516 (kinda) (#91571) ## About The Pull Request Ports @PowerfulBacon's 516 screentip fix (changing `cursor_hints.dmi` from 8x5 to 16x16) from https://github.com/BeeStation/BeeStation-Hornet/pull/11938 there's some weird spacing issues, but it _works_ at least (i would greatly appreciate someone figuring out how to fix that, tho). ![2025-06-10 (1749590843) ~ dreamseeker](https://github.com/user-attachments/assets/75ce528d-b09a-4c0e-9f13-77b05561a772) ## Why It's Good For The Game i want my fancy icons back ## Changelog :cl: Absolucy, PowerfulBacon fix: Screentip icons work on the latest BYOND 516 again. /:cl: --- code/__DEFINES/client.dm | 6 ------ code/game/atom/_atom.dm | 3 --- icons/ui/screentips/cursor_hints.dmi | Bin 309 -> 338 bytes 3 files changed, 9 deletions(-) diff --git a/code/__DEFINES/client.dm b/code/__DEFINES/client.dm index 0008a736acd..453bd1aaeeb 100644 --- a/code/__DEFINES/client.dm +++ b/code/__DEFINES/client.dm @@ -5,11 +5,5 @@ /// Should return the boolean value of the fully_created var, which should be TRUE if New() has finished running. FALSE otherwise. #define VALIDATE_CLIENT_INITIALIZATION(target) (target.fully_created) -/// The minimum client BYOND build to disable screentip icons for. -#define MIN_BYOND_BUILD_DISABLE_SCREENTIP_ICONS 1657 -/// The maximum client BYOND build to disable screentip icons for. -/// Update this whenever https://www.byond.com/forum/post/2967731 is fixed. -#define MAX_BYOND_BUILD_DISABLE_SCREENTIP_ICONS 1699 - /// Aghosting AND APPERANTLY STEALTHMINNING sets your ckey/key == "@[old_key]" because it hates me. this detects that #define IS_FAKE_KEY(key) (key && key[1] == "@") diff --git a/code/game/atom/_atom.dm b/code/game/atom/_atom.dm index 2cf8db6360c..c368c87ffe3 100644 --- a/code/game/atom/_atom.dm +++ b/code/game/atom/_atom.dm @@ -881,9 +881,6 @@ if (contextual_screentip_returns & CONTEXTUAL_SCREENTIP_SET) var/screentip_images = active_hud.screentip_images - // Disable screentip images for clients affected by https://www.byond.com/forum/post/2967731 - if(ISINRANGE(client?.byond_build, MIN_BYOND_BUILD_DISABLE_SCREENTIP_ICONS, MAX_BYOND_BUILD_DISABLE_SCREENTIP_ICONS)) - screentip_images = FALSE // LMB and RMB on one line... var/lmb_text = build_context(context, SCREENTIP_CONTEXT_LMB, screentip_images) var/rmb_text = build_context(context, SCREENTIP_CONTEXT_RMB, screentip_images) diff --git a/icons/ui/screentips/cursor_hints.dmi b/icons/ui/screentips/cursor_hints.dmi index 2fdbb2d04d50bb8f651c044e61195f5630facc74..dde4f1e70724dd73b79e367cee6ae4ec7134f98f 100644 GIT binary patch delta 295 zcmV+?0oeYv0@4B{iBL{Q4GJ0x0000DNk~Le0000W0000W2nGNE0CReJ^Z)<=a*-u9 ze+0dLzYTy7;ekq-N zsgym4=gtq^VZ>#3*Xw=s_ij?~rW!f_c>@f<01UtYtJo3IwV$UBt8mtnw4dy25ckS@n#GU%d1?*lz9*vRO QMF0Q*07*qoM6N<$f}oIX!T