cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-30 00:29:02 +01:00
Code Issues Packages Projects Releases Wiki Activity

[MIRROR] Prevents nulls in the always_visible_inventory list (which caused runtimes blocking PM reapplication) [MDB IGNORE] (#19329)

Browse Source 
* Prevents nulls in the always_visible_inventory list (which caused runtimes blocking PM reapplication) (#73400)

## About The Pull Request

Attempting to add a null to images (even in a list) is a runtime, which
in this case blocks off the rest of show_hud, breaking planemasters and
other shit

## Why It's Good For The Game

Closes #73387, closes #73364

## Changelog
🆑
fix: Equipping an fov item, disconnecting, waiting 6 minutes and
reconnecting will no longer break your game
/🆑

* Prevents nulls in the always_visible_inventory list (which caused runtimes blocking PM reapplication)

---------

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
This commit is contained in:
SkyratBot
2023-02-14 02:18:00 +00:00
committed by GitHub
co-authored by LemonInTheDark
parent bd3fd77d82
commit 78da484056
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/datums/components/fov_handler.dm
+4 -2
View File
@@ -97,13 +97,15 @@
/datum/component/fov_handler/proc/remove_mask()
var/mob/parent_mob = parent
var/client/parent_client = parent_mob.client
// Prevents stupid ass hard deletes
parent_mob.hud_used.always_visible_inventory -= blocker_mask
parent_mob.hud_used.always_visible_inventory -= visual_shadow
if(!parent_client) //Love client volatility!!
return
applied_mask = FALSE
parent_client.screen -= blocker_mask
parent_client.screen -= visual_shadow
parent_mob.hud_used.always_visible_inventory -= blocker_mask
parent_mob.hud_used.always_visible_inventory -= visual_shadow
/datum/component/fov_handler/proc/add_mask()
var/mob/parent_mob = parent