cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-22 04:30:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Splits placeontop proc (#79702)

Browse Source 
## About The Pull Request
I find the proc hard to read honestly. There's no reason we can't split
this into two functions - the secondary functionality is used only once,
in reader.dmm.
## Why It's Good For The Game
Code improvement
Glorious snake case
## Changelog
N/A nothing player facing

---------

Co-authored-by: san7890 <34697715+san7890@users.noreply.github.com>
This commit is contained in:
Jeremiah
2023-11-19 04:58:31 +01:00
committed by GitHub
co-authored by san7890
parent a396f3c129
commit 7a1b1fa9ad
31 changed files with 84 additions and 96 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/game/objects/structures/false_walls.dm
+2 -2
View File
@@ -78,7 +78,7 @@
/obj/structure/falsewall/proc/ChangeToWall(delete = 1)
var/turf/T = get_turf(src)
T.PlaceOnTop(walltype)
T.place_on_top(walltype)
if(delete)
qdel(src)
return T
@@ -404,7 +404,7 @@
/obj/structure/falsewall/material/ChangeToWall(delete = 1)
var/turf/current_turf = get_turf(src)
var/turf/closed/wall/material/new_wall = current_turf.PlaceOnTop(/turf/closed/wall/material)
var/turf/closed/wall/material/new_wall = current_turf.place_on_top(/turf/closed/wall/material)
new_wall.set_custom_materials(custom_materials)
if(delete)
qdel(src)
code/game/objects/structures/girders.dm
+8 -8
View File
@@ -99,7 +99,7 @@
return
rod.use(amount)
var/turf/T = get_turf(src)
T.PlaceOnTop(/turf/closed/wall/mineral/iron)
T.place_on_top(/turf/closed/wall/mineral/iron)
transfer_fingerprints_to(T)
qdel(src)
return
@@ -149,7 +149,7 @@
return
sheets.use(amount)
var/turf/T = get_turf(src)
T.PlaceOnTop(/turf/closed/wall)
T.place_on_top(/turf/closed/wall)
transfer_fingerprints_to(T)
qdel(src)
return
@@ -194,7 +194,7 @@
return
sheets.use(amount)
var/turf/T = get_turf(src)
T.PlaceOnTop(/turf/closed/wall/r_wall)
T.place_on_top(/turf/closed/wall/r_wall)
transfer_fingerprints_to(T)
qdel(src)
return
@@ -271,9 +271,9 @@
sheets.use(amount)
var/turf/T = get_turf(src)
if(sheets.walltype)
T.PlaceOnTop(sheets.walltype)
T.place_on_top(sheets.walltype)
else
var/turf/newturf = T.PlaceOnTop(/turf/closed/wall/material)
var/turf/newturf = T.place_on_top(/turf/closed/wall/material)
var/list/material_list = list()
material_list[GET_MATERIAL_REF(sheets.material_type)] = SHEET_MATERIAL_AMOUNT * 2
if(material_list)
@@ -453,7 +453,7 @@
return
R.use(amount)
var/turf/T = get_turf(src)
T.PlaceOnTop(/turf/closed/wall/mineral/cult)
T.place_on_top(/turf/closed/wall/mineral/cult)
qdel(src)
else
@@ -488,7 +488,7 @@
return FALSE
var/turf/T = get_turf(src)
T.PlaceOnTop(/turf/closed/wall)
T.place_on_top(/turf/closed/wall)
qdel(src)
return TRUE
if(RCD_DECONSTRUCT)
@@ -525,7 +525,7 @@
return
B.use(amount)
var/turf/T = get_turf(src)
T.PlaceOnTop(/turf/closed/wall/mineral/bronze)
T.place_on_top(/turf/closed/wall/mineral/bronze)
qdel(src)
else
code/game/objects/structures/lattice.dm
+1 -1
View File
@@ -73,7 +73,7 @@
if(design_structure == /turf/open/floor/plating)
var/turf/T = src.loc
if(isgroundlessturf(T))
T.PlaceOnTop(/turf/open/floor/plating, flags = CHANGETURF_INHERIT_AIR)
T.place_on_top(/turf/open/floor/plating, flags = CHANGETURF_INHERIT_AIR)
qdel(src)
return TRUE
if(design_structure == /obj/structure/lattice/catwalk)