Fix April Fools and Roundend title music (#89741)

## About The Pull Request

1. April Fools set the lobby music, but order of operations says
holidays might be initialized before ticker. So we need to ensure it
won't get overridden.
2. Lobby music pref was changed from a toggle to a number, but the proc
already passed the number as an argument, so the arg did nothing. Now
it'll (properly) play at half volume during end-of-round.
3. When using default repo lobby music, it will not play the same music
after two rounds (as it does with configured lobby music)

## Changelog

🆑 Melbert
fix: Roundend title music will play at half volume again
fix: April Fools lobby music will correctly always be clown music
fix: Lobby Music will repeat across sequential rounds less often
/🆑
This commit is contained in:
MrMelbert
2025-03-01 14:53:15 +01:00
committed by GitHub
parent 8f4607884d
commit 7a5aecf825
4 changed files with 19 additions and 10 deletions
+1 -1
View File
@@ -257,7 +257,7 @@
/datum/holiday/april_fools/celebrate()
. = ..()
SSjob.set_overflow_role(/datum/job/clown)
SSticker.login_music = 'sound/music/lobby_music/clown.ogg'
SSticker.set_lobby_music('sound/music/lobby_music/clown.ogg', override = TRUE)
for(var/i in GLOB.new_player_list)
var/mob/dead/new_player/P = i
if(P.client)