cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-25 06:00:16 +01:00
Code Issues Packages Projects Releases Wiki Activity

Void cloaks do not block surgery while invisibile (#95804)

Browse Source 
## About The Pull Request

fixes https://github.com/tgstation/tgstation/issues/95803

The void cloak and its hood do not obstruct body parts for things such
as surgery. I guess it also lets you shave a heretic while their hood is
on but that seems kind of funny.

## Why It's Good For The Game

A) This is going to result in a lot of complications due to the strip
menu obscuring that the void cloak has.

B) It also gets rid of some meta tells that you have the cloak. 

Honestly, I wonder if it would be better if this was a neck item and the
'hood' is just an abstraction, but that's kind of exiting the realm of a
fix at that point.

## Changelog
🆑
fix: Void cloaks no longer obstruct surgery while invisible.
/🆑

---------

Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Co-authored-by: SyncIt21 <110812394+SyncIt21@users.noreply.github.com>
This commit is contained in:
necromanceranne
2026-05-01 21:38:01 -04:00
committed by GitHub
co-authored by MrMelbert SyncIt21
parent e88c41216e
commit 7aa5fb5d06
4 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/antagonists/heretic/items/heretic_armor.dm
+5 -3
View File
@@ -1114,13 +1114,13 @@
// Void cloak. Turns invisible with the hood up, lets you hide stuff.
/obj/item/clothing/head/hooded/cult_hoodie/void
name = "void hood"
icon = 'icons/obj/clothing/head/helmet.dmi'
worn_icon = 'icons/mob/clothing/head/helmet.dmi'
desc = "Black like tar, reflecting no light. Runic symbols line the outside. \
With each flash you lose comprehension of what you are seeing."
icon = 'icons/obj/clothing/head/helmet.dmi'
worn_icon = 'icons/mob/clothing/head/helmet.dmi'
icon_state = "void_cloak"
flags_inv = NONE
flags_cover = NONE
flags_cover = ALLOW_SURGERY_THROUGH
armor_type = /datum/armor/cult_hoodie_void
/datum/armor/cult_hoodie_void
@@ -1221,6 +1221,7 @@
/obj/item/clothing/suit/hooded/cultrobes/void/proc/make_invisible()
add_traits(list(TRAIT_NO_STRIP, TRAIT_EXAMINE_SKIP), REF(src))
RemoveElement(/datum/element/heretic_focus)
flags_cover |= ALLOW_SURGERY_THROUGH
if(isliving(loc))
loc.remove_traits(list(TRAIT_RESISTLOWPRESSURE, TRAIT_RESISTCOLD), REF(src))
@@ -1232,6 +1233,7 @@
/obj/item/clothing/suit/hooded/cultrobes/void/proc/make_visible()
remove_traits(list(TRAIT_NO_STRIP, TRAIT_EXAMINE_SKIP), REF(src))
AddElement(/datum/element/heretic_focus)
flags_cover &= ~ALLOW_SURGERY_THROUGH
if(isliving(loc))
loc.add_traits(list(TRAIT_RESISTLOWPRESSURE, TRAIT_RESISTCOLD), REF(src))
code/modules/mob/living/carbon/inventory.dm
+2
View File
@@ -444,6 +444,8 @@
for(var/obj/item/worn_item in get_equipped_items(INCLUDE_ABSTRACT))
if(worn_item.slot_flags & exluded_equipment_slots)
continue
if(worn_item.flags_cover & ALLOW_SURGERY_THROUGH)
continue
covered_flags |= worn_item.body_parts_covered
// NB: we have to convert covered_flags via cover_flags2body_zones here
code/modules/unit_tests/surgeries.dm
+4
View File
@@ -244,6 +244,10 @@
var/obj/item/clothing/under/jumpsuit = test_mob.get_item_by_slot(ITEM_SLOT_ICLOTHING)
jumpsuit.adjust_to_alt()
TEST_ASSERT(test_mob.is_location_accessible(BODY_ZONE_CHEST), "Chest should be accessible after rolling jumpsuit down")
jumpsuit.adjust_to_alt()
jumpsuit.flags_cover |= ALLOW_SURGERY_THROUGH
TEST_ASSERT(test_mob.is_location_accessible(BODY_ZONE_CHEST), "Chest should be accessible if it has the ALLOW_SURGERY_THROUGH flag")
/// Tests surgeries which just modify basic surgical states
/datum/unit_test/state_surgeries