mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-08-24 21:48:39 +01:00
Removes unused parameter times_fired from mob procs (#94590)
## About The Pull Request What it says on the tin. `times_fired` is the most unused parameter in all mob procs. I say most because there were just 2 cases where it was used - handling breathing - handling heartbeat Besides these 2 cases this parameter did nothing in every proc. Removing it does 2 things - Makes those procs more readable as it now has 1 less parameter that was documented poorly and did nothing - Makes those procs slightly faster as we are passing 1 less variable to its parameter call stack It can easily be substituted with `SSmobs.times_fired` which was its original value anyways ## Changelog 🆑 code: removes an unused parameter `times_fired` from mob life procs. Making them function slightly faster /🆑
This commit is contained in:
@@ -35,7 +35,7 @@
|
||||
qdel(src)
|
||||
|
||||
// Every x seconds, if on lavaland, add one stack
|
||||
/obj/item/organ/monster_core/brimdust_sac/on_life(seconds_per_tick, times_fired)
|
||||
/obj/item/organ/monster_core/brimdust_sac/on_life(seconds_per_tick)
|
||||
. = ..()
|
||||
if(!COOLDOWN_FINISHED(src, brimdust_auto_apply_cooldown))
|
||||
return
|
||||
|
||||
@@ -25,7 +25,7 @@
|
||||
return
|
||||
SSblackbox.record_feedback("nested tally", "hivelord_core", 1, list("[type]", "inert"))
|
||||
|
||||
/obj/item/organ/monster_core/regenerative_core/on_life(seconds_per_tick, times_fired)
|
||||
/obj/item/organ/monster_core/regenerative_core/on_life(seconds_per_tick)
|
||||
. = ..()
|
||||
if (owner.health <= owner.crit_threshold)
|
||||
trigger_organ_action(TRIGGER_FORCE_AVAILABLE)
|
||||
|
||||
@@ -16,7 +16,7 @@
|
||||
user_status = /datum/status_effect/lobster_rush
|
||||
actions_types = list(/datum/action/cooldown/monster_core_action/adrenal_boost)
|
||||
|
||||
/obj/item/organ/monster_core/rush_gland/on_life(seconds_per_tick, times_fired)
|
||||
/obj/item/organ/monster_core/rush_gland/on_life(seconds_per_tick)
|
||||
. = ..()
|
||||
if (owner.health <= HEALTH_DANGER_ZONE)
|
||||
trigger_organ_action()
|
||||
|
||||
Reference in New Issue
Block a user