mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-08-29 08:08:49 +01:00
[NO GBP] fixing a few issues with fishing and aquariums (#93964)
## About The Pull Request Played around with fishing and aquariums the other day. While it has come a long way, aquariums are still a pain in the ass in many ways and there are still things that don't work as intended as well as some pet peeves. This PR: - removes code that didn't work to begin with (rotating the fish when mounted on for fish trophy wallmounts) - fixes the predator and necrophage traits triggering when the fish is NOT hungry and on fishes that are bigger than the not-so-hungry fish, rather than smaller. - Add an examine line to fish tanks when full. - Fixes evolution probability for self-reproducing fishes (purple sludgefish should be 1 in 20, not 1 in 40) - Fixes fish analyzers not being usable on equipped/held items. - Nit with examine lines for fishing rods. - Experiments handler devices won't announce when an experiment that they cannot perform is completed. The big exception is the generic experi-scanner. This means fish analyzers and operating computers will no longer bug you about material scan experiments being completed. - the ping sound from using lures should be a smidge louder and can be heard from more than 1 tile away. ## Why It's Good For The Game Issues with fishing and aquariums mainly, also a smidge of a code improvement for experiment handlers. ## Changelog 🆑 fix: Fixed some fishes trying to eat other (bigger) fish while not hungry. Also a nit with purple sludgefish being a bit too rare. fix: Fixes fish analyzers not working with held or equipped fish or aquariums (not in your backpack). balance: Fish analyzers and operating computers no longer announce completed experiments that they aren't compatible with. balance: the ping sound from using fishing lures should be a smidge louder and can be heard from more than 1 tile away. qol: Examining fish tanks (the item) when they're almost full will warn you about it. /🆑
This commit is contained in:
@@ -558,10 +558,6 @@
|
||||
if(experiment.type != paper_to_add.experiment_path)
|
||||
continue
|
||||
|
||||
experiment.completed = TRUE
|
||||
var/announcetext = complete_experiment(experiment)
|
||||
if(length(GLOB.experiment_handlers))
|
||||
var/datum/component/experiment_handler/handler = GLOB.experiment_handlers[1]
|
||||
handler.announce_message_to_all(announcetext)
|
||||
experiment.finish_experiment(linked_web_override = src)
|
||||
|
||||
return TRUE
|
||||
|
||||
Reference in New Issue
Block a user