From 7f613ca2dcee74db8fa95a599bc6ee52307cfda0 Mon Sep 17 00:00:00 2001
From: Ghom <42542238+Ghommie@users.noreply.github.com>
Date: Thu, 10 Aug 2023 18:53:19 +0200
Subject: [PATCH] [NO GBP] Mirror reflections no longer display progress bars
 or runechat. (#77446)

## About The Pull Request
I was thoroughfully worried this would had been a cursed issue until I
figured it out. Mirror reflections now use render targets to copy the
appearance of the reflected movable, not vis overlays, with a couple
caveats.

## Why It's Good For The Game
This will fix #77431.

## Changelog

:cl:
fix: Mirror reflections no longer display progress bars or runechat.
/:cl:
---
 code/datums/components/reflection.dm | 20 +++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

diff --git a/code/datums/components/reflection.dm b/code/datums/components/reflection.dm
index b8b51359ec6..cb411720f7f 100644
--- a/code/datums/components/reflection.dm
+++ b/code/datums/components/reflection.dm
@@ -11,7 +11,7 @@
 	 */
 	var/reflected_dir
 	/// the movable which the reflected movables are attached to, in turn added to the vis contents of the parent.
-	var/atom/movable/reflection_holder
+	var/obj/effect/abstract/reflection_holder
 	/// A lazy assoc list that keeps track of which movables are being reflected and the associated reflections.
 	var/list/reflected_movables
 	/// A callback used check to know which movables should be reflected and which not.
@@ -34,22 +34,21 @@
 		COMSIG_ATOM_AFTER_SUCCESSFUL_INITIALIZED_ON = PROC_REF(on_movable_entered_or_initialized),
 		COMSIG_ATOM_EXITED = PROC_REF(on_movable_exited)
 	)
-	var/atom/movable/mov_parent = parent
 	AddComponent(/datum/component/connect_range, parent, connections, 1, works_in_containers = FALSE)
 	src.reflected_dir = reflected_dir
 	src.reflection_matrix = reflection_matrix
 	src.reflection_filter = reflection_filter
 	src.can_reflect = can_reflect
-	reflection_holder = new
+	reflection_holder = new(parent)
 	reflection_holder.alpha = alpha
 	reflection_holder.appearance_flags = KEEP_TOGETHER
 	reflection_holder.vis_flags = VIS_INHERIT_ID
-	reflection_holder.alpha = alpha
 	reflection_holder.mouse_opacity = MOUSE_OPACITY_TRANSPARENT
 	if(reflection_filter)
 		reflection_holder.add_filter("reflection", 1, reflection_filter)
-	mov_parent.vis_contents += reflection_holder
 
+	var/atom/movable/mov_parent = parent
+	mov_parent.vis_contents += reflection_holder
 	set_reflection(new_dir = mov_parent.dir)
 
 	RegisterSignal(parent, COMSIG_ATOM_DIR_CHANGE, PROC_REF(on_dir_change))
@@ -112,8 +111,15 @@
 ///Sets up a visual overlay of the target movables, which is added to the parent's vis contents.
 /datum/component/reflection/proc/set_reflected(atom/movable/target)
 	SIGNAL_HANDLER
-	var/atom/movable/reflection = new
-	reflection.vis_contents += target
+	/**
+	 * If the loc is null, only a black (or grey depending on alpha) silhouette of the target will be rendered
+	 * Just putting this information here in case you want something like that in the future.
+	 */
+	var/obj/effect/abstract/reflection = new(parent)
+	reflection.vis_flags = VIS_INHERIT_ID
+	if(!target.render_target)
+		target.render_target = REF(target)
+	reflection.render_source = target.render_target
 	///The filter is added to the reflection holder; the matrix is not, otherwise that'd go affecting the filter.
 	if(reflection_matrix)
 		reflection.transform = reflection_matrix