[MIRROR] Removes side effects in Destroy from cyborgs, misc related code cleanup [MDB IGNORE] (#22575)

* Removes side effects in Destroy from cyborgs, misc related code cleanup (#76867)

## About The Pull Request

- Removes side effects from cyborg `Destroy`
- Right result in more cyborgs getting dusted... Will have to check this
out.

- General AI / cyborg code cleanup

Fixes #76855

## Why It's Good For The Game

Some more consistent, clean code

## Changelog

🆑 Melbert
fix: Cyborgs no longer drop their radio key when deleted, only when
deconstructed first
fix: Cyborgs no longer drop their MMI on deletion, only prior to
deletion. This may result in bad code rearing its ugly head, open an
issue report on the github if you're a cyborg and get ghosted when you
feel like you shouldn't
fix: Runtime from syndie cyborgs spawning
fix: AI deaths are reported to black box
/🆑

---------

Co-authored-by: Jacquerel <hnevard@ gmail.com>

* Removes side effects in Destroy from cyborgs, misc related code cleanup

---------

Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Co-authored-by: Jacquerel <hnevard@ gmail.com>
This commit is contained in:
SkyratBot
2023-07-19 02:58:40 +02:00
committed by GitHub
parent 2cbf139d17
commit 7f6a3cea58
11 changed files with 91 additions and 88 deletions
+1 -2
View File
@@ -316,8 +316,7 @@
chest.cell.forceMove(O)
W.forceMove(O)//Should fix cybros run time erroring when blown up. It got deleted before, along with the frame.
if(O.mmi) //we delete the mmi created by robot/New()
qdel(O.mmi)
QDEL_NULL(O.mmi) //we delete the mmi created by robot/New()
O.mmi = W //and give the real mmi to the borg.
O.updatename(brainmob.client)
// This canonizes that MMI'd cyborgs have memories of their previous life