From 81955f8e650c9f7674fc7312e1711d7a890f2e7f Mon Sep 17 00:00:00 2001
From: Seris02 <49109742+Seris02@users.noreply.github.com>
Date: Sun, 12 Dec 2021 14:20:05 +0800
Subject: [PATCH] fixes an exploit (#10029)

---
 code/modules/client/preferences/middleware/jobs.dm | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/code/modules/client/preferences/middleware/jobs.dm b/code/modules/client/preferences/middleware/jobs.dm
index 07f1137fd19..d227c01128b 100644
--- a/code/modules/client/preferences/middleware/jobs.dm
+++ b/code/modules/client/preferences/middleware/jobs.dm
@@ -27,12 +27,21 @@
 	preferences.character_preview_view?.update_body()
 
 	return TRUE
+
 // SKYRAT EDIT
 /datum/preference_middleware/jobs/proc/set_job_title(list/params, mob/user)
-	var/default_job_title = params["job"]
+	var/job_title = params["job"]
 	var/new_job_title = params["new_title"]
 
-	preferences.alt_job_titles[default_job_title] = new_job_title
+	var/datum/job/job = SSjob.GetJob(job_title)
+
+	if (isnull(job))
+		return FALSE
+
+	if (!(new_job_title in job.alt_titles))
+		return FALSE
+
+	preferences.alt_job_titles[job_title] = new_job_title
 
 	return TRUE
 // SKYRAT EDIT END