mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-08-27 23:27:34 +01:00
[MIRROR] Removes some code soul (IF YOU ARE COPY PASTING THIS...), replaces it with a macro [MDB IGNORE] (#25272)
* Removes some code soul (`IF YOU ARE COPY PASTING THIS...`), replaces it with a macro (#79935) ## About The Pull Request Replaces all instances of `SSblackbox.record_feedback\("tally", "admin_verb", 1, (.+)\)` with `BLACKBOX_LOG_ADMIN_VERB($1)` This makes so the funny comment isn't necessary. It also reveals one location which someone did not heed the comment, the `debug_controller` proc copy+pasted the line but did not change the fourth argument. PEOPLE DON'T READ! * Removes some code soul (`IF YOU ARE COPY PASTING THIS...`), replaces it with a macro --------- Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
This commit is contained in:
@@ -30,7 +30,7 @@
|
||||
confidential = TRUE)
|
||||
return
|
||||
cmd_admin_pm(M.client, null)
|
||||
SSblackbox.record_feedback("tally", "admin_verb", 1, "Admin PM Mob") // If you are copy-pasting this, ensure the 4th parameter is unique to the new proc!
|
||||
BLACKBOX_LOG_ADMIN_VERB("Admin PM Mob")
|
||||
|
||||
/// Shows a list of clients we could send PMs to, then forwards our choice to cmd_admin_pm
|
||||
/client/proc/cmd_admin_pm_panel()
|
||||
@@ -63,7 +63,7 @@
|
||||
if (isnull(target))
|
||||
return
|
||||
cmd_admin_pm(targets[target], null)
|
||||
SSblackbox.record_feedback("tally", "admin_verb", 1, "Admin PM") // If you are copy-pasting this, ensure the 4th parameter is unique to the new proc!
|
||||
BLACKBOX_LOG_ADMIN_VERB("Admin PM")
|
||||
|
||||
/// Replys to some existing ahelp, reply to whom, which can be a client or ckey
|
||||
/client/proc/cmd_ahelp_reply(whom)
|
||||
|
||||
Reference in New Issue
Block a user