cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-30 16:47:13 +01:00
Code Issues Packages Projects Releases Wiki Activity

[MIRROR] Removes some code soul (IF YOU ARE COPY PASTING THIS...), replaces it with a macro [MDB IGNORE] (#25272)

Browse Source 
* Removes some code soul (`IF YOU ARE COPY PASTING THIS...`), replaces it with a macro (#79935)

## About The Pull Request

Replaces all instances of `SSblackbox.record_feedback\("tally",
"admin_verb", 1, (.+)\)` with `BLACKBOX_LOG_ADMIN_VERB($1)`

This makes so the funny comment isn't necessary.

It also reveals one location which someone did not heed the comment, the
`debug_controller` proc copy+pasted the line but did not change the
fourth argument. PEOPLE DON'T READ!

* Removes some code soul (`IF YOU ARE COPY PASTING THIS...`), replaces it with a macro

---------

Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
This commit is contained in:
SkyratBot
2023-11-27 01:02:37 -05:00
committed by GitHub
co-authored by MrMelbert
parent 0ad91010ac
commit 84e42fd0eb
37 changed files with 144 additions and 140 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/admin/verbs/mapping.dm
+10 -10
View File
@@ -77,7 +77,7 @@ GLOBAL_PROTECT(admin_verbs_debug_mapping)
seen[T]++
for(var/turf/T in seen)
T.maptext = MAPTEXT(seen[T])
SSblackbox.record_feedback("tally", "admin_verb", 1, "Show Camera Range") // If you are copy-pasting this, ensure the 4th parameter is unique to the new proc!
BLACKBOX_LOG_ADMIN_VERB("Show Camera Range")
#ifdef TESTING
GLOBAL_LIST_EMPTY(dirty_vars)
@@ -134,7 +134,7 @@ GLOBAL_LIST_EMPTY(dirty_vars)
output += "</ul>"
usr << browse(output,"window=airreport;size=1000x500")
SSblackbox.record_feedback("tally", "admin_verb", 1, "Show Camera Report") // If you are copy-pasting this, ensure the 4th parameter is unique to the new proc!
BLACKBOX_LOG_ADMIN_VERB("Show Camera Report")
/client/proc/intercom_view()
set category = "Mapping"
@@ -151,7 +151,7 @@ GLOBAL_LIST_EMPTY(dirty_vars)
for(var/obj/item/radio/intercom/intercom in GLOB.all_radios[frequency])
for(var/turf/turf in view(7,intercom.loc))
new /obj/effect/abstract/marker/intercom(turf)
SSblackbox.record_feedback("tally", "admin_verb", 1, "Show Intercom Range") // If you are copy-pasting this, ensure the 4th parameter is unique to the new proc!
BLACKBOX_LOG_ADMIN_VERB("Show Intercom Range")
/client/proc/show_map_reports()
set category = "Mapping"
@@ -180,7 +180,7 @@ GLOBAL_LIST_EMPTY(dirty_vars)
usr << browse(dat, "window=at_list")
SSblackbox.record_feedback("tally", "admin_verb", 1, "Show Roundstart Active Turfs") // If you are copy-pasting this, ensure the 4th parameter is unique to the new proc!
BLACKBOX_LOG_ADMIN_VERB("Show Roundstart Active Turfs")
/client/proc/cmd_show_at_markers()
set category = "Mapping"
@@ -200,7 +200,7 @@ GLOBAL_LIST_EMPTY(dirty_vars)
count++
to_chat(usr, "[count] AT markers placed.", confidential = TRUE)
SSblackbox.record_feedback("tally", "admin_verb", 1, "Show Roundstart Active Turf Markers")
BLACKBOX_LOG_ADMIN_VERB("Show Roundstart Active Turf Markers")
/client/proc/enable_mapping_verbs()
set category = "Debug"
@@ -209,14 +209,14 @@ GLOBAL_LIST_EMPTY(dirty_vars)
return
remove_verb(src, /client/proc/enable_mapping_verbs)
add_verb(src, list(/client/proc/disable_mapping_verbs, GLOB.admin_verbs_debug_mapping))
SSblackbox.record_feedback("tally", "admin_verb", 1, "Enable Debug Verbs") // If you are copy-pasting this, ensure the 4th parameter is unique to the new proc!
BLACKBOX_LOG_ADMIN_VERB("Enable Debug Verbs")
/client/proc/disable_mapping_verbs()
set category = "Debug"
set name = "Mapping verbs - Disable"
remove_verb(src, list(/client/proc/disable_mapping_verbs, GLOB.admin_verbs_debug_mapping))
add_verb(src, /client/proc/enable_mapping_verbs)
SSblackbox.record_feedback("tally", "admin_verb", 1, "Disable Debug Verbs") // If you are copy-pasting this, ensure the 4th parameter is unique to the new proc!
BLACKBOX_LOG_ADMIN_VERB("Disable Debug Verbs")
/client/proc/count_objects_on_z_level()
set category = "Mapping"
@@ -255,7 +255,7 @@ GLOBAL_LIST_EMPTY(dirty_vars)
atom_list += A
to_chat(world, "There are [count] objects of type [type_path] on z-level [num_level]", confidential = TRUE)
SSblackbox.record_feedback("tally", "admin_verb", 1, "Count Objects Zlevel") // If you are copy-pasting this, ensure the 4th parameter is unique to the new proc!
BLACKBOX_LOG_ADMIN_VERB("Count Objects Zlevel")
/client/proc/count_objects_all()
set category = "Mapping"
@@ -275,7 +275,7 @@ GLOBAL_LIST_EMPTY(dirty_vars)
count++
to_chat(world, "There are [count] objects of type [type_path] in the game world", confidential = TRUE)
SSblackbox.record_feedback("tally", "admin_verb", 1, "Count Objects All") // If you are copy-pasting this, ensure the 4th parameter is unique to the new proc!
BLACKBOX_LOG_ADMIN_VERB("Count Objects All")
//This proc is intended to detect lag problems relating to communication procs
@@ -470,7 +470,7 @@ GLOBAL_VAR_INIT(say_disabled, FALSE)
to_chat(src, "Only administrators may use this command.", confidential = TRUE)
return
message_admins(span_adminnotice("[key_name_admin(usr)] is checking for obstructed atmospherics through the debug command."))
SSblackbox.record_feedback("tally", "admin_verb", 1, "Check For Obstructed Atmospherics") // If you are copy-pasting this, ensure the 4th parameter is unique to the new proc!
BLACKBOX_LOG_ADMIN_VERB("Check For Obstructed Atmospherics")
var/list/results = list()