[MIRROR] Adds a modular computer subsystem to shift modPCs away from radios [MDB IGNORE] (#17942)

* Adds a modular computer subsystem to shift modPCs away from radios (#71732)

## About The Pull Request

Adds the modular computer subsystem which is meant to replace mod PC's
reliance on networks and radios, specifically the network subsystem, the
ntnet interface, and /datum/ntnet. This PR removes station_root ntnets
entirely, but I tried to keep it small.

This PR also removes a ton of unused vars and defines, such as NTNet
channels that were unused (peer2peer and systemcontrol), atmos networks
(as they were removed a while ago) and NTNet var on relays (its stated
purpose is so admins can see it through varedits, but that's useless now
that it's a subsystem)

I also removed ``setting_disabled`` as a thing the RD can do, it turned
off ALL ntnet systems. However, this was when there were 4 different
ones, now that there's only 2 I thought it was redundant and he could
just click 2 buttons to close them.

## Why It's Good For The Game

``/datum/ntnet``, ``/datum/component/ntnet_interface``, and
``/datum/controller/subsystem/networks`` are all old-code messes that
depend on eachother and is hard for people to understand what exactly it
adds to the game. 90% of its features is allowing the Wirecarp app to
see all the ruins that spawned in-game, which I don't think is something
that we even WANT (why does the RD need to know that oldstation spawned?
Why should they know this anyway??)

This hopefully starts to simplify networks/ntnet to make it easier to
remove in the future, because surely there are better alternatives than
**this**

## Changelog

🆑
refactor: Modular computers NTnet and applications run on its own
subsystem, please report any new bugs you may find.
/🆑

* Adds a modular computer subsystem to shift modPCs away from radios

* Fixed contractor uplink

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: tastyfish <crazychris32@gmail.com>

code/modules/modular_computers/file_system/programs/antagonist/dos.dm

@@ -46,9 +46,9 @@
 		return
 	switch(action)
 		if("PRG_target_relay")
-			for(var/obj/machinery/ntnet_relay/R in SSnetworks.relays)
-				if(R.uid == params["targid"])
-					target = R
+			for(var/obj/machinery/ntnet_relay/relays as anything in SSmodular_computers.ntnet_relays)
+				if(relays.uid == params["targid"])
+					target = relays
 					break
 			return TRUE
 		if("PRG_reset")
@@ -62,15 +62,12 @@
 			if(target)
 				executed = TRUE
 				target.dos_sources.Add(src)
-				if(SSnetworks.station_network.intrusion_detection_enabled)
+				if(SSmodular_computers.intrusion_detection_enabled)
 					SSnetworks.add_log("IDS WARNING - Excess traffic flood targeting relay [target.uid] detected from device: [computer.name]")
-					SSnetworks.station_network.intrusion_detection_alarm = TRUE
+					SSmodular_computers.intrusion_detection_alarm = TRUE
 			return TRUE
 
 /datum/computer_file/program/ntnet_dos/ui_data(mob/user)
-	if(!SSnetworks.station_network)
-		return
-
 	var/list/data = get_header_data()
 
 	data["error"] = error
@@ -83,8 +80,8 @@
 	else
 		data["target"] = FALSE
 		data["relays"] = list()
-		for(var/obj/machinery/ntnet_relay/R in SSnetworks.relays)
-			data["relays"] += list(list("id" = R.uid))
+		for(var/obj/machinery/ntnet_relay/relays as anything in SSmodular_computers.ntnet_relays)
+			data["relays"] += list(list("id" = relays.uid))
 		data["focus"] = target ? target.uid : null
 
 	return data

code/modules/modular_computers/file_system/programs/ntdownloader.dm

@@ -20,6 +20,7 @@
 	var/emagged = FALSE
 	var/list/main_repo
 	var/list/antag_repo
+
 	var/list/show_categories = list(
 		PROGRAM_CATEGORY_CREW,
 		PROGRAM_CATEGORY_ENGI,
@@ -30,8 +31,8 @@
 
 /datum/computer_file/program/ntnetdownload/on_start()
 	. = ..()
-	main_repo = SSnetworks.station_network.available_station_software
-	antag_repo = SSnetworks.station_network.available_antag_software
+	main_repo = SSmodular_computers.available_station_software
+	antag_repo = SSmodular_computers.available_antag_software
 
 /datum/computer_file/program/ntnetdownload/run_emag()
 	if(emagged)
@@ -44,7 +45,7 @@
 	if(downloaded_file)
 		return FALSE
 
-	var/datum/computer_file/program/PRG = SSnetworks.station_network.find_ntnet_file_by_name(filename)
+	var/datum/computer_file/program/PRG = SSmodular_computers.find_ntnet_file_by_name(filename)
 
 	if(!PRG || !istype(PRG))
 		return FALSE
@@ -158,7 +159,7 @@
 			"installed" = !!computer.find_file_by_name(programs.filename),
 			"compatible" = check_compatibility(programs),
 			"size" = programs.size,
-			"access" = emagged && programs.available_on_syndinet ? TRUE : programs.can_run(user,transfer = 1, access = access),
+			"access" = emagged && programs.available_on_syndinet ? TRUE : programs.can_run(user,transfer = TRUE, access = access),
 			"verifiedsource" = programs.available_on_ntnet,
 		))
 
@@ -195,5 +196,5 @@
 
 /datum/computer_file/program/ntnetdownload/syndicate/on_start()
 	. = ..()
-	main_repo = SSnetworks.station_network.available_antag_software
+	main_repo = SSmodular_computers.available_antag_software
 	antag_repo = null

code/modules/modular_computers/file_system/programs/ntnrc_client.dm

@@ -53,7 +53,7 @@
 	if(.)
 		return
 
-	var/datum/ntnet_conversation/channel = SSnetworks.station_network.get_chat_channel_by_id(active_channel)
+	var/datum/ntnet_conversation/channel = SSmodular_computers.get_chat_channel_by_id(active_channel)
 	var/authed = FALSE
 	if(channel && ((channel.channel_operator == src) || netadmin_mode))
 		authed = TRUE
@@ -84,7 +84,7 @@
 				return TRUE
 
 			active_channel = new_target
-			channel = SSnetworks.station_network.get_chat_channel_by_id(new_target)
+			channel = SSmodular_computers.get_chat_channel_by_id(new_target)
 			if((!(src in channel.active_clients) && !(src in channel.offline_clients)) && !channel.password)
 				channel.add_client(src)
 			return TRUE
@@ -106,7 +106,7 @@
 				return UI_UPDATE
 			var/mob/living/user = usr
 			if(can_run(user, TRUE, ACCESS_NETWORK))
-				for(var/datum/ntnet_conversation/channels as anything in SSnetworks.station_network.chat_channels)
+				for(var/datum/ntnet_conversation/channels as anything in SSmodular_computers.chat_channels)
 					channels.remove_client(src)
 				netadmin_mode = TRUE
 				return UI_UPDATE
@@ -115,7 +115,7 @@
 			newname = replacetext(newname, " ", "_")
 			if(!newname || newname == username)
 				return
-			for(var/datum/ntnet_conversation/anychannel as anything in SSnetworks.station_network.chat_channels)
+			for(var/datum/ntnet_conversation/anychannel as anything in SSmodular_computers.chat_channels)
 				if(src in anychannel.active_clients)
 					anychannel.add_status_message("[username] is now known as [newname].")
 			username = newname
@@ -180,7 +180,7 @@
 
 /datum/computer_file/program/chatclient/process_tick(delta_time)
 	. = ..()
-	var/datum/ntnet_conversation/channel = SSnetworks.station_network.get_chat_channel_by_id(active_channel)
+	var/datum/ntnet_conversation/channel = SSmodular_computers.get_chat_channel_by_id(active_channel)
 	if(program_state != PROGRAM_STATE_KILLED)
 		ui_header = "ntnrc_idle.gif"
 		if(channel)
@@ -198,13 +198,13 @@
 	. = ..()
 	if(!.)
 		return
-	for(var/datum/ntnet_conversation/channel as anything in SSnetworks.station_network.chat_channels)
+	for(var/datum/ntnet_conversation/channel as anything in SSmodular_computers.chat_channels)
 		if(src in channel.offline_clients)
 			channel.offline_clients.Remove(src)
 			channel.active_clients.Add(src)
 
 /datum/computer_file/program/chatclient/kill_program(forced = FALSE)
-	for(var/datum/ntnet_conversation/channel as anything in SSnetworks.station_network.chat_channels)
+	for(var/datum/ntnet_conversation/channel as anything in SSmodular_computers.chat_channels)
 		channel.go_offline(src)
 	active_channel = null
 	return ..()
@@ -219,11 +219,11 @@
 
 /datum/computer_file/program/chatclient/ui_data(mob/user)
 	var/list/data = get_header_data()
-	if(!SSnetworks.station_network || !SSnetworks.station_network.chat_channels)
+	if(!SSmodular_computers.chat_channels)
 		return data
 
 	var/list/all_channels = list()
-	for(var/datum/ntnet_conversation/conversations as anything in SSnetworks.station_network.chat_channels)
+	for(var/datum/ntnet_conversation/conversations as anything in SSmodular_computers.chat_channels)
 		if(conversations.title)
 			all_channels.Add(list(list(
 				"chan" = conversations.title,
@@ -232,7 +232,7 @@
 	data["all_channels"] = all_channels
 	data["active_channel"] = active_channel
 
-	var/datum/ntnet_conversation/channel = SSnetworks.station_network.get_chat_channel_by_id(active_channel)
+	var/datum/ntnet_conversation/channel = SSmodular_computers.get_chat_channel_by_id(active_channel)
 	var/authed = FALSE
 	data["clients"] = list()
 	data["messages"] = list()

code/modules/modular_computers/file_system/programs/wirecarp.dm

@@ -17,42 +17,22 @@
 		return
 	switch(action)
 		if("resetIDS")
-			if(SSnetworks.station_network)
-				SSnetworks.station_network.resetIDS()
+			SSmodular_computers.intrusion_detection_alarm = FALSE
 			return TRUE
 		if("toggleIDS")
-			if(SSnetworks.station_network)
-				SSnetworks.station_network.toggleIDS()
-			return TRUE
-		if("toggleWireless")
-			if(!SSnetworks.station_network)
-				return
-
-			// NTNet is disabled. Enabling can be done without user prompt
-			if(SSnetworks.station_network.setting_disabled)
-				SSnetworks.station_network.setting_disabled = FALSE
-				return TRUE
-
-			SSnetworks.station_network.setting_disabled = TRUE
+			SSmodular_computers.intrusion_detection_enabled = !SSmodular_computers.intrusion_detection_enabled
 			return TRUE
 		if("purgelogs")
-			if(SSnetworks.station_network)
-				SSnetworks.purge_logs()
+			SSnetworks.purge_logs()
 			return TRUE
 		if("updatemaxlogs")
 			var/logcount = params["new_number"]
-			if(SSnetworks.station_network)
-				SSnetworks.update_max_log_count(logcount)
+			SSnetworks.update_max_log_count(logcount)
 			return TRUE
 		if("toggle_function")
-			if(!SSnetworks.station_network)
-				return
-			SSnetworks.station_network.toggle_function(text2num(params["id"]))
+			SSmodular_computers.toggle_function(text2num(params["id"]))
 			return TRUE
 		if("toggle_mass_pda")
-			if(!SSnetworks.station_network)
-				return
-
 			var/obj/item/modular_computer/target_tablet = locate(params["ref"]) in GLOB.TabletMessengers
 			if(!istype(target_tablet))
 				return
@@ -60,30 +40,24 @@
 				messenger_app.spam_mode = !messenger_app.spam_mode
 
 /datum/computer_file/program/ntnetmonitor/ui_data(mob/user)
-	if(!SSnetworks.station_network)
-		return
 	var/list/data = get_header_data()
 
-	data["ntnetstatus"] = SSnetworks.station_network.check_function()
-	data["ntnetrelays"] = SSnetworks.relays.len
-	data["idsstatus"] = SSnetworks.station_network.intrusion_detection_enabled
-	data["idsalarm"] = SSnetworks.station_network.intrusion_detection_alarm
+	data["ntnetstatus"] = SSmodular_computers.check_function()
+	data["ntnetrelays"] = SSmodular_computers.ntnet_relays.len
 
-	data["config_softwaredownload"] = SSnetworks.station_network.setting_softwaredownload
-	data["config_peertopeer"] = SSnetworks.station_network.setting_peertopeer
-	data["config_communication"] = SSnetworks.station_network.setting_communication
-	data["config_systemcontrol"] = SSnetworks.station_network.setting_systemcontrol
+	data["config_softwaredownload"] = SSmodular_computers.setting_softwaredownload
+	data["config_communication"] = SSmodular_computers.setting_communication
+
+	data["idsstatus"] = SSmodular_computers.intrusion_detection_enabled
+	data["idsalarm"] = SSmodular_computers.intrusion_detection_alarm
 
 	data["ntnetlogs"] = list()
-	data["minlogs"] = MIN_NTNET_LOGS
-	data["maxlogs"] = MAX_NTNET_LOGS
-
 	for(var/i in SSnetworks.logs)
 		data["ntnetlogs"] += list(list("entry" = i))
 	data["ntnetmaxlogs"] = SSnetworks.setting_maxlogcount
 
 	data["tablets"] = list()
-	for(var/obj/item/modular_computer/messenger in GetViewableDevices())
+	for(var/obj/item/modular_computer/messenger as anything in GetViewableDevices())
 		var/list/tablet_data = list()
 		if(messenger.saved_identification)
 			for(var/datum/computer_file/program/messenger/messenger_app in computer.stored_files)
@@ -95,3 +69,9 @@
 		data["tablets"] += list(tablet_data)
 
 	return data
+
+/datum/computer_file/program/ntnetmonitor/ui_static_data(mob/user)
+	var/list/data = ..()
+	data["minlogs"] = MIN_NTNET_LOGS
+	data["maxlogs"] = MAX_NTNET_LOGS
+	return data