From 86eb20f0cd28f7d9d6ebd389ad89d3c24a2cfbd7 Mon Sep 17 00:00:00 2001 From: MrMelbert <51863163+MrMelbert@users.noreply.github.com> Date: Fri, 20 Jun 2025 11:01:00 -0500 Subject: [PATCH] Fix meteor announce runtime (#91719) ## About The Pull Request `if(GLOB.meteor_list)` will always pass because it's always a list, it should be checking for length. At least from what I can tell. --- code/modules/events/meteors/stray_meteor_event.dm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/code/modules/events/meteors/stray_meteor_event.dm b/code/modules/events/meteors/stray_meteor_event.dm index 53daff1ac8a..4b780d7d72d 100644 --- a/code/modules/events/meteors/stray_meteor_event.dm +++ b/code/modules/events/meteors/stray_meteor_event.dm @@ -27,7 +27,7 @@ spawn_meteor(GLOB.meteors_stray) /datum/round_event/stray_meteor/announce(fake) - if(GLOB.meteor_list) + if(length(GLOB.meteor_list)) var/obj/effect/meteor/detected_meteor = pick(GLOB.meteor_list) //If we accidentally pick a meteor not spawned by the event, we're still technically not wrong var/sensor_name = detected_meteor.signature priority_announce("Our [sensor_name] sensors have detected an incoming signature approaching [GLOB.station_name]. Please brace for impact.", "Meteor Alert")