From 88dffc2f06927fdcc519482391c2871bbed5bb87 Mon Sep 17 00:00:00 2001
From: grungussuss <96586172+grungussuss@users.noreply.github.com>
Date: Wed, 30 Apr 2025 22:23:55 +0300
Subject: [PATCH] Fixes Bane element runtime (#90889)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
I spotted this when I used throw mode to hit my lizard character with
the officer's sabre

`check_biotype_path` in the bane element typecasts bane_applier into
`/mob/living/bane_applier` and then checks for
`bane_applier.combat_mode` , which runtimes if `bane_applier` doesn't
actually have combat_mode.

instead, let's typecast `bane_applier` into an atom and check if it's
living down the line.
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->

## Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and its effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->

:cl: grungussuss
fix: fixes bane element not working if it was used by a weapon without a
wielder
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Co-authored-by: SmArtKar <44720187+SmArtKar@users.noreply.github.com>
---
 code/datums/elements/bane.dm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/code/datums/elements/bane.dm b/code/datums/elements/bane.dm
index 110a755de23..769cf8d361d 100644
--- a/code/datums/elements/bane.dm
+++ b/code/datums/elements/bane.dm
@@ -76,12 +76,13 @@
  * Checks typepaths and the mob's biotype, returning TRUE if correct and FALSE if wrong.
  * Additionally checks if combat mode is required, and if so whether it's enabled or not.
  */
-/datum/element/bane/proc/check_biotype_path(mob/living/bane_applier, atom/target)
+/datum/element/bane/proc/check_biotype_path(atom/bane_applier, atom/target)
 	if(!isliving(target))
 		return FALSE
 	var/mob/living/living_target = target
-	if(bane_applier)
-		if(requires_combat_mode && !bane_applier.combat_mode)
+	if(isliving(bane_applier) && bane_applier)
+		var/mob/living/living_bane_applier = bane_applier
+		if(requires_combat_mode && !living_bane_applier.combat_mode)
 			return FALSE
 	var/is_correct_biotype = living_target.mob_biotypes & mob_biotypes
 	if(mob_biotypes && !(is_correct_biotype))