Fully implements the ID Card design document (#56910)

Co-authored-by: Rohesie <rohesie@gmail.com>

code/modules/mining/laborcamp/laborstacker.dm

@@ -56,8 +56,8 @@ GLOBAL_LIST(labor_sheet_values)
 	if(isliving(usr))
 		var/mob/living/L = usr
 		I = L.get_idcard(TRUE)
-	if(istype(I, /obj/item/card/id/prisoner))
-		var/obj/item/card/id/prisoner/P = I
+	if(istype(I, /obj/item/card/id/advanced/prisoner))
+		var/obj/item/card/id/advanced/prisoner/P = I
 		data["id_points"] = P.points
 		if(P.points >= P.goal)
 			can_go_home = TRUE
@@ -86,8 +86,8 @@ GLOBAL_LIST(labor_sheet_values)
 			if(isliving(M))
 				var/mob/living/L = M
 				I = L.get_idcard(TRUE)
-			if(istype(I, /obj/item/card/id/prisoner))
-				var/obj/item/card/id/prisoner/P = I
+			if(istype(I, /obj/item/card/id/advanced/prisoner))
+				var/obj/item/card/id/advanced/prisoner/P = I
 				P.points += stacking_machine.points
 				stacking_machine.points = 0
 				to_chat(M, "<span class='notice'>Points transferred.</span>")
@@ -157,8 +157,8 @@ GLOBAL_LIST(labor_sheet_values)
 
 /obj/machinery/mineral/labor_points_checker/attackby(obj/item/I, mob/user, params)
 	if(istype(I, /obj/item/card/id))
-		if(istype(I, /obj/item/card/id/prisoner))
-			var/obj/item/card/id/prisoner/prisoner_id = I
+		if(istype(I, /obj/item/card/id/advanced/prisoner))
+			var/obj/item/card/id/advanced/prisoner/prisoner_id = I
 			to_chat(user, "<span class='notice'><B>ID: [prisoner_id.registered_name]</B></span>")
 			to_chat(user, "<span class='notice'>Points Collected:[prisoner_id.points]</span>")
 			to_chat(user, "<span class='notice'>Point Quota: [prisoner_id.goal]</span>")

code/modules/mining/machine_vending.dm

@@ -212,7 +212,7 @@
 /obj/machinery/mineral/equipment_vendor/golem/Initialize()
 	desc += "\nIt seems a few selections have been added."
 	prize_list += list(
-		new /datum/data/mining_equipment("Extra Id", /obj/item/card/id/mining, 250),
+		new /datum/data/mining_equipment("Extra Id", /obj/item/card/id/advanced/mining, 250),
 		new /datum/data/mining_equipment("Science Goggles", /obj/item/clothing/glasses/science, 250),
 		new /datum/data/mining_equipment("Monkey Cube", /obj/item/food/monkeycube, 300),
 		new /datum/data/mining_equipment("Toolbelt", /obj/item/storage/belt/utility, 350),
@@ -257,24 +257,6 @@
 	..()
 	to_chat(user, "<span class='alert'>There's [points] point\s on the card.</span>")
 
-///Conscript kit
-/obj/item/card/mining_access_card
-	name = "mining access card"
-	desc = "A small card, that when used on any ID, will add mining access."
-	icon_state = "data_1"
-
-/obj/item/card/mining_access_card/afterattack(atom/movable/AM, mob/user, proximity)
-	. = ..()
-	if(istype(AM, /obj/item/card/id) && proximity)
-		var/obj/item/card/id/I = AM
-		I.access |= ACCESS_MINING
-		I.access |= ACCESS_MINING_STATION
-		I.access |= ACCESS_MECH_MINING
-		I.access |= ACCESS_MINERAL_STOREROOM
-		I.access |= ACCESS_CARGO
-		to_chat(user, "<span class='notice'>You upgrade [I] with mining access.</span>")
-		qdel(src)
-
 /obj/item/storage/backpack/duffelbag/mining_conscript
 	name = "mining conscription kit"
 	desc = "A kit containing everything a crewmember needs to support a shaft miner in the field."
@@ -288,7 +270,7 @@
 	new /obj/item/clothing/suit/hooded/explorer(src)
 	new /obj/item/encryptionkey/headset_mining(src)
 	new /obj/item/clothing/mask/gas/explorer(src)
-	new /obj/item/card/mining_access_card(src)
+	new /obj/item/card/id/advanced/mining(src)
 	new /obj/item/gun/energy/kinetic_accelerator(src)
 	new /obj/item/kitchen/knife/combat/survival(src)
 	new /obj/item/flashlight/seclite(src)

code/modules/mining/minebot.dm

@@ -55,13 +55,11 @@
 	var/obj/item/implant/radio/mining/imp = new(src)
 	imp.implant(src)
 
-	access_card = new /obj/item/card/id(src)
-	var/datum/job/mining/M = new
-	access_card.access = M.get_access()
+	access_card = new /obj/item/card/id/advanced/gold(src)
+	SSid_access.apply_trim_to_card(access_card, /datum/id_trim/job/shaft_miner)
 
 	SetCollectBehavior()
 
-
 /mob/living/simple_animal/hostile/mining_drone/Destroy()
 	for (var/datum/action/innate/minedrone/action in actions)
 		qdel(action)