cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-07-12 16:44:43 +01:00
Code Issues Packages Projects Releases Wiki Activity

[MIRROR] Fixing a number of issues with burial mounds and abandoned crates. [MDB IGNORE] (#11197)

Browse Source 
* Fixing a number of issues with burial mounds and abandoned crates. (#64482)

Ok, I'm fixing a few issues with certain crates, namely the abandoned one and the burial mound:

    An oversight with the skittish trait letting players dive into burial mounds, which are technically a subtype of crates.
    A runtime that made abandoned crates not update their lock lights when unlocked (the togglelock call was missing the user arg). This one was my fault.
    An oversight with abandoned crates not resetting the number of attempts left and not nulling the last attempted code when re-locked. Idem.
    Burial mounds somehow getting lock lights overlays.

Also i'm taking this opportunity to make the closets unit test not early return at the first encountered failure (at the time I made it I didn't know TEST_ASSERT & co would early return on failure) since we want this unit test to finish looping through all non-blacklisted closets.

* Fixing a number of issues with burial mounds and abandoned crates.

Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
This commit is contained in:
SkyratBot
2022-02-01 05:24:04 +01:00
committed by GitHub
parent 856fd64cd5
commit 8a6a71ffeb
4 changed files with 18 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/unit_tests/closets.dm
+2 -1
View File
@@ -9,4 +9,5 @@
for(var/closet_type in all_closets)
var/obj/structure/closet/closet = allocate(closet_type)
var/contents_len = length(closet.contents)
TEST_ASSERT(contents_len <= closet.storage_capacity, "Initial Contents of [closet.type] ([contents_len]) exceed its storage capacity ([closet.storage_capacity]).")
if(contents_len > closet.storage_capacity)
Fail("Initial Contents of [closet.type] ([contents_len]) exceed its storage capacity ([closet.storage_capacity]).")