[MIRROR] Move current pick_weight consumers to not pass in zeros [MDB IGNORE] (#9647)

* Move current pick_weight consumers to not pass in zeros (#62940)

About The Pull Request

pick_weight_allow_zero was a backwards compatible hack, so it exists alongside pick_weight.

I would really like to just remove the old proc and just rename it, so I want to log what, if anything, is relying on this behavior, to see if it's a bug or if it needs to be handled especially in that case.

* Move current pick_weight consumers to not pass in zeros

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>

code/datums/looping_sounds/item_sounds.dm

@@ -1,20 +1,20 @@
 /datum/looping_sound/reverse_bear_trap
-	mid_sounds = list('sound/effects/clock_tick.ogg')
+	mid_sounds = list('sound/effects/clock_tick.ogg' = 1)
 	mid_length = 3.5
 	volume = 25
 
 
 /datum/looping_sound/reverse_bear_trap_beep
-	mid_sounds = list('sound/machines/beep.ogg')
+	mid_sounds = list('sound/machines/beep.ogg' = 1)
 	mid_length = 60
 	volume = 10
 
 /datum/looping_sound/siren
-	mid_sounds = list('sound/items/weeoo1.ogg')
+	mid_sounds = list('sound/items/weeoo1.ogg' = 1)
 	mid_length = 15
 	volume = 20
 
 /datum/looping_sound/tape_recorder_hiss
-	mid_sounds = list('sound/items/taperecorder/taperecorder_hiss_mid.ogg')
-	start_sound = list('sound/items/taperecorder/taperecorder_hiss_start.ogg')
+	mid_sounds = list('sound/items/taperecorder/taperecorder_hiss_mid.ogg' = 1)
+	start_sound = list('sound/items/taperecorder/taperecorder_hiss_start.ogg' = 1)
 	volume = 10

code/datums/looping_sounds/machinery_sounds.dm

@@ -94,7 +94,7 @@
 
 /datum/looping_sound/jackpot
 	mid_length = 11
-	mid_sounds = list('sound/machines/roulettejackpot.ogg')
+	mid_sounds = list('sound/machines/roulettejackpot.ogg'=1)
 	volume = 85
 	vary = TRUE