cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-21 20:20:33 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fixes a fair few execute() errors in dynamic midround rulesets (#69130)

Browse Source
This commit is contained in:
tralezab
2022-08-18 17:02:40 -07:00
committed by GitHub
parent 7c25d7cb8a
commit 8c1366933d
3 changed files with 38 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/unit_tests/dynamic_ruleset_sanity.dm
+5 -1
View File
@@ -11,7 +11,11 @@
else if (!has_scaling_cost && !is_lone)
TEST_FAIL("[ruleset] has no scaling cost, but is also not a lone/highlander ruleset.")
for (var/datum/dynamic_ruleset/midround/ruleset as anything in subtypesof(/datum/dynamic_ruleset/midround) - /datum/dynamic_ruleset/midround/from_ghosts)
for (var/datum/dynamic_ruleset/midround/ruleset as anything in subtypesof(/datum/dynamic_ruleset/midround))
if(initial(ruleset.abstract_type) == ruleset)
if(initial(ruleset.weight))
TEST_FAIL("[ruleset] is abstract and should never run, it should also have 0 weight set.")
continue
var/midround_ruleset_style = initial(ruleset.midround_ruleset_style)
if (midround_ruleset_style != MIDROUND_RULESET_STYLE_HEAVY && midround_ruleset_style != MIDROUND_RULESET_STYLE_LIGHT)
TEST_FAIL("[ruleset] has an invalid midround_ruleset_style, it should be MIDROUND_RULESET_STYLE_HEAVY or MIDROUND_RULESET_STYLE_LIGHT")