From 8db012a90f6fa4c52ffa2ec499f632315ed2bbae Mon Sep 17 00:00:00 2001
From: grungussuss <96586172+Sadboysuss@users.noreply.github.com>
Date: Wed, 12 Jun 2024 02:28:49 +0300
Subject: [PATCH] White dwarf meta knowledge check fix (#83633)
## About The Pull Request
There is two values for round threat, the shown value and the real
value, sometimes the shown threat can be 0, while the real threat is
higher, which in turn does not trigger the green alert on getting the
classified report and does not make a special announcement, "Thanks to
the tireless efforts of our security and intelligence divisions, there
are currently no credible threats to [station_name()]. All station
construction projects have been authorized. Have a secure shift!", nor
does it enable all station construction projects, so we should disable
being able to fake white dwarf on classified report.
## Why It's Good For The Game
Knowing when your classified report is fake is meta knowledge and
shouldn't be a thing.
## Changelog
:cl: grungussuss
fix: fixed getting a fake white dwarf report when the shift isn't
extended mode, which lead to meta knowledge being used.
/:cl:
---
code/controllers/subsystem/dynamic/dynamic.dm | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/code/controllers/subsystem/dynamic/dynamic.dm b/code/controllers/subsystem/dynamic/dynamic.dm
index e23fc7e64db..e34b0c7e446 100644
--- a/code/controllers/subsystem/dynamic/dynamic.dm
+++ b/code/controllers/subsystem/dynamic/dynamic.dm
@@ -385,12 +385,14 @@ SUBSYSTEM_DEF(dynamic)
advisory_string += "Advisory Level: Pulsar Star
"
advisory_string += "Your sector's advisory level is Pulsar Star. A large, unknown electromagnetic field has stormed through nearby surveillance equipment, causing major data loss. Partial data was recovered and showed no credible threats to Nanotrasen assets within the Spinward Sector; however, the Department of Intelligence advises maintaining high alert against potential threats due to the lack of complete data."
return advisory_string
+ //a white dwarf shift leads to a green security alert on report and special announcement, this prevents a meta check if the alert report is fake or not.
+ if(round(shown_threat) == 0 && round(threat_level) == 0)
+ advisory_string += "Advisory Level: White Dwarf
"
+ advisory_string += "Your sector's advisory level is White Dwarf. Our surveillance has ruled out any and all potential threats known in our database, eliminating most risks to our assets in the Spinward Sector. We advise a lower level of security, alongside distributing resources on potential profit."
+ return advisory_string
switch(round(shown_threat))
- if(0)
- advisory_string += "Advisory Level: White Dwarf
"
- advisory_string += "Your sector's advisory level is White Dwarf. Our surveillance has ruled out any and all potential threats known in our database, eliminating most risks to our assets in the Spinward Sector. We advise a lower level of security, alongside distributing resources on potential profit."
- if(1 to 19)
+ if(0 to 19)
var/show_core_territory = (GLOB.current_living_antags.len > 0)
if (prob(FAKE_GREENSHIFT_FORM_CHANCE))
show_core_territory = !show_core_territory