mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-08-29 08:08:49 +01:00
OpenDream Cleanup Pass (#67036)
OpenDream can detect BYONDisms that BYOND or SpacemanDMM miss. This PR fixes all of the issues it found in TG. Each change is explained in code comments below.
This commit is contained in:
@@ -91,8 +91,9 @@
|
||||
. = user.transferItemToLoc(I, parent)
|
||||
|
||||
// Using stacks
|
||||
else if(istype(I, /obj/item/stack))
|
||||
. = I.use_tool(parent, user, 0, volume=50, amount=current_step["amount"])
|
||||
else
|
||||
if(istype(I, /obj/item/stack))
|
||||
. = I.use_tool(parent, user, 0, volume=50, amount=current_step["amount"])
|
||||
|
||||
|
||||
// Going backwards? Undo the last action. Drop/respawn the items used in last action, if any.
|
||||
@@ -108,8 +109,9 @@
|
||||
if(located_item)
|
||||
located_item.forceMove(drop_location())
|
||||
|
||||
else if(ispath(target_step_key, /obj/item/stack))
|
||||
new target_step_key(drop_location(), target_step["amount"])
|
||||
else
|
||||
if(ispath(target_step_key, /obj/item/stack))
|
||||
new target_step_key(drop_location(), target_step["amount"])
|
||||
|
||||
/datum/component/construction/proc/spawn_result()
|
||||
// Some constructions result in new components being added.
|
||||
|
||||
@@ -130,11 +130,11 @@
|
||||
holder = null
|
||||
|
||||
// Disposal pipes related shits
|
||||
/datum/component/squeak/proc/disposing_react(datum/source, obj/structure/disposalholder/holder, obj/machinery/disposal/source)
|
||||
/datum/component/squeak/proc/disposing_react(datum/source, obj/structure/disposalholder/disposal_holder, obj/machinery/disposal/disposal_source)
|
||||
SIGNAL_HANDLER
|
||||
|
||||
//We don't need to worry about unregistering this signal as it will happen for us automaticaly when the holder is qdeleted
|
||||
RegisterSignal(holder, COMSIG_ATOM_DIR_CHANGE, .proc/holder_dir_change)
|
||||
RegisterSignal(disposal_holder, COMSIG_ATOM_DIR_CHANGE, .proc/holder_dir_change)
|
||||
|
||||
/datum/component/squeak/proc/holder_dir_change(datum/source, old_dir, new_dir)
|
||||
SIGNAL_HANDLER
|
||||
|
||||
Reference in New Issue
Block a user