Alt click refactor (#82656)

## About The Pull Request
Rewrites how alt click works. 
Based heavily on #82625. What a cool concept, it flows nicely with
#82533.

Fixes #81242 
(tm bugs fixed)
Fixes #82668

<details><summary>More info for devs</summary>

Handy regex used for alt click s&r:
`AltClick\((.*).*\)(\n\t.*\.\.\(\))?`
`click_alt($1)` (yes I am aware this only copies the first arg. there
are no other args!)

### Obj reskins
No reason for obj reskin to check on every single alt click for every
object. It applies to only a few items.
- Moved to obj/item
- Made into signal
- Added screentips

### Ventcrawling
Every single atmospherics machine checked for ventcrawling capability on
alt click despite only 3 objects needing that functionality. This has
been moved down to those individual items.
</details>

## Why It's Good For The Game
For players: 
- Alt clicking should work more logically, not causing double actions
like eject disk and open item window
- Added context menus for reskinnable items
- Removed adjacency restriction on loot panel

For devs:
- Makes alt click interactions easier to work with, no more click chain
nonsense and redundant guard clauses.
- OOP hell reduced
- Pascal Case reduced
- Glorious snake case

## Changelog
🆑
add: The lootpanel now works at range.
add: Screentips for reskinnable items.
fix: Alt click interactions have been refactored, which may lead to
unintentional changes to gameplay. Report any issues, please.
/🆑
This commit is contained in:
Jeremiah
2024-04-16 17:48:03 -06:00
committed by GitHub
parent 37aad4720d
commit 8e3f635b98
192 changed files with 1031 additions and 1038 deletions
+7 -4
View File
@@ -51,10 +51,13 @@
return
edit_emitter(user)
/obj/effect/sound_emitter/AltClick(mob/user)
if(check_rights_for(user.client, R_SOUND))
activate(user)
to_chat(user, span_notice("Sound emitter activated."), confidential = TRUE)
/obj/effect/sound_emitter/click_alt(mob/user)
if(!check_rights_for(user.client, R_SOUND))
return CLICK_ACTION_BLOCKING
activate(user)
to_chat(user, span_notice("Sound emitter activated."), confidential = TRUE)
return CLICK_ACTION_SUCCESS
/obj/effect/sound_emitter/proc/edit_emitter(mob/user)
var/dat = ""