[MIRROR] AIs can now select portraits as their display (#1739)

* AIs can now select portraits as their display

* a

* Update tgui.bundle.js

Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>
Co-authored-by: Azarak <azarak10@gmail.com>

code/modules/mob/living/silicon/ai/ai.dm

@@ -138,7 +138,8 @@
 	if(client)
 		INVOKE_ASYNC(src, .proc/apply_pref_name,"ai",client)
 
-	set_core_display_icon()
+	INVOKE_ASYNC(src, .proc/set_core_display_icon)
+
 
 	holo_icon = getHologramIcon(icon('icons/mob/ai.dmi',"default"))
 
@@ -237,11 +238,17 @@
 	set name = "Set AI Core Display"
 	if(incapacitated())
 		return
+	icon = initial(icon)
+	icon_state = "ai"
+	cut_overlays()
 	var/list/iconstates = GLOB.ai_core_display_screens
 	for(var/option in iconstates)
 		if(option == "Random")
 			iconstates[option] = image(icon = src.icon, icon_state = "ai-random")
 			continue
+		if(option == "Portrait")
+			iconstates[option] = image(icon = src.icon, icon_state = "ai-portrait")
+			continue
 		iconstates[option] = image(icon = src.icon, icon_state = resolve_ai_icon(option))
 
 	view_core()

code/modules/mob/living/silicon/ai/ai_portrait_picker.dm

@@ -0,0 +1,78 @@
+
+//Portrait picker! It's a tgui window that lets you look through all the portraits, and choose one as your AI.
+
+//very similar to centcom_podlauncher in terms of how this is coded, so i kept a lot of comments from it
+//^ wow! it's the second time i've said this! i'm a real coder now, copying my statement of copying other people's stuff.
+
+
+#define TAB_LIBRARY 1
+#define TAB_SECURE 2
+#define TAB_PRIVATE 3
+
+/datum/portrait_picker
+	var/client/holder //client of whoever is using this datum
+
+/datum/portrait_picker/New(user)//user can either be a client or a mob due to byondcode(tm)
+	if (istype(user, /client))
+		var/client/user_client = user
+		holder = user_client //if its a client, assign it to holder
+	else
+		var/mob/user_mob = user
+		holder = user_mob.client //if its a mob, assign the mob's client to holder
+
+/datum/portrait_picker/ui_interact(mob/user, datum/tgui/ui)
+	ui = SStgui.try_update_ui(user, src, ui)
+	if(!ui)
+		ui = new(user, src, "PortraitPicker")
+		ui.open()
+
+/datum/portrait_picker/ui_close()
+	qdel(src)
+
+/datum/portrait_picker/ui_state(mob/user)
+	return GLOB.conscious_state
+
+/datum/portrait_picker/ui_assets(mob/user)
+	return list(
+		get_asset_datum(/datum/asset/simple/portraits/library),
+		get_asset_datum(/datum/asset/simple/portraits/library_secure),
+		get_asset_datum(/datum/asset/simple/portraits/library_private)
+	)
+
+/datum/portrait_picker/ui_data(mob/user)
+	var/list/data = list()
+	data["library"] = SSpersistence.paintings["library"] ? SSpersistence.paintings["library"] : 0
+	data["library_secure"] = SSpersistence.paintings["library_secure"] ? SSpersistence.paintings["library_secure"] : 0
+	data["library_private"] = SSpersistence.paintings["library_private"] ? SSpersistence.paintings["library_private"] : 0 //i'm gonna regret this, won't i?
+	return data
+
+/datum/portrait_picker/ui_act(action, params)
+	. = ..()
+	if(.)
+		return
+	switch(action)
+		if("select")
+			var/list/tab2key = list(TAB_LIBRARY = "library", TAB_SECURE = "library_secure", TAB_PRIVATE = "library_private")
+			var/folder = tab2key[params["tab"]]
+			var/list/current_list = SSpersistence.paintings[folder]
+			var/list/chosen_portrait = current_list[params["selected"]]
+			var/png = "data/paintings/[folder]/[chosen_portrait["md5"]].png"
+			var/icon/portrait_icon = new(png)
+			var/mob/living/ai = holder.mob
+			var/w = portrait_icon.Width()
+			var/h = portrait_icon.Height()
+			var/mutable_appearance/MA = mutable_appearance(portrait_icon)
+			if(w == 23 || h == 23)
+				to_chat(ai, "<span class='notice'>Small note: 23x23 Portraits are accepted, but they do not fit perfectly inside the display frame.</span>")
+				MA.pixel_x = 5
+				MA.pixel_y = 5
+			else if(w == 24 || h == 24)
+				to_chat(ai, "<span class='notice'>Portrait Accepted. Enjoy!</span>")
+				MA.pixel_x = 4
+				MA.pixel_y = 4
+			else
+				to_chat(ai, "<span class='warning'>Sorry, only 23x23 and 24x24 Portraits are accepted.</span>")
+				return
+			ai.cut_overlays() //so people can't keep repeatedly select portraits to add stacking overlays
+			ai.icon_state = "ai-portrait-active"//background
+			ai.add_overlay(MA)

code/modules/mob/living/silicon/ai/death.dm

@@ -4,6 +4,7 @@
 
 	. = ..()
 
+	cut_overlays() //remove portraits
 	var/old_icon = icon_state
 	if("[icon_state]_dead" in icon_states(icon))
 		icon_state = "[icon_state]_dead"