From 9220e5ef712dca221cce9764c1fc0edd5add1351 Mon Sep 17 00:00:00 2001 From: Timberpoes Date: Wed, 9 Feb 2022 23:46:27 +0000 Subject: [PATCH] Fix random job assignments occasionally assigning to roles that were already filled (#64734) Missing continue in the random job assignment code meant an if statement was ineffective, code fell through and assigned roles to jobs that were already full. --- code/controllers/subsystem/job.dm | 1 + 1 file changed, 1 insertion(+) diff --git a/code/controllers/subsystem/job.dm b/code/controllers/subsystem/job.dm index 79c4546857c..3e79ee5d441 100644 --- a/code/controllers/subsystem/job.dm +++ b/code/controllers/subsystem/job.dm @@ -241,6 +241,7 @@ SUBSYSTEM_DEF(job) if((job.current_positions >= job.spawn_positions) && job.spawn_positions != -1) JobDebug("GRJ job lacks spawn positions to be eligible, Player: [player], Job: [job]") + continue if(istype(job, GetJobType(overflow_role))) // We don't want to give him assistant, that's boring! JobDebug("GRJ skipping overflow role, Player: [player], Job: [job]")