cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-31 09:08:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

Kills /datum/asset/var/_abstract, uses abstract_type instead (#95756)

Browse Source 
## About The Pull Request

It's all in the title

## Why It's Good For The Game

Forgotten in #92909

## Changelog

no player facing changes
This commit is contained in:
mrmanlikesbt
2026-04-13 17:20:12 -04:00
committed by GitHub
parent 1eb84a8c00
commit 928df286a6
8 changed files with 19 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/unit_tests/asset_smart_cache.dm
+1 -1
View File
@@ -3,7 +3,7 @@
load_immediately = TRUE
force_cache = TRUE
// Don't let the asset subsystem load this. This is how we trick it.
_abstract = /datum/asset/spritesheet_batched/test
abstract_type = /datum/asset/spritesheet_batched/test
var/static/list/items = list(/obj/item/binoculars, /obj/item/camera, /obj/item/clothing/under/color/blue, /obj/item/clothing/under/color/black)
/datum/asset/spritesheet_batched/test/create_spritesheets()
code/modules/unit_tests/spritesheets.dm
+2 -6
View File
@@ -2,22 +2,18 @@
/datum/unit_test/spritesheets
/datum/unit_test/spritesheets/Run()
for(var/datum/asset/spritesheet/sheet as anything in subtypesof(/datum/asset/spritesheet))
for(var/datum/asset/spritesheet/sheet as anything in valid_subtypesof(/datum/asset/spritesheet))
if(!initial(sheet.name)) //Ignore abstract types
continue
if (sheet == initial(sheet._abstract))
continue
sheet = get_asset_datum(sheet)
for(var/sprite_name in sheet.sprites)
if(!sprite_name)
TEST_FAIL("Spritesheet [sheet.type] has a nameless icon state.")
// Test IconForge generated sheets as well
for(var/datum/asset/spritesheet_batched/sheet as anything in subtypesof(/datum/asset/spritesheet_batched))
for(var/datum/asset/spritesheet_batched/sheet as anything in valid_subtypesof(/datum/asset/spritesheet_batched))
if(!initial(sheet.name)) //Ignore abstract types
continue
if (sheet == initial(sheet._abstract))
continue
sheet = get_asset_datum(sheet)
for(var/sprite_name in sheet.sprites)
if(!sprite_name)