cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2025-12-09 16:05:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix screentips on 516 (kinda) (#91571)

Browse Source 
## About The Pull Request

Ports @PowerfulBacon's 516 screentip fix (changing `cursor_hints.dmi`
from 8x5 to 16x16) from
https://github.com/BeeStation/BeeStation-Hornet/pull/11938

there's some weird spacing issues, but it _works_ at least (i would
greatly appreciate someone figuring out how to fix that, tho).

![2025-06-10 (1749590843) ~
dreamseeker](https://github.com/user-attachments/assets/75ce528d-b09a-4c0e-9f13-77b05561a772)

## Why It's Good For The Game

i want my fancy icons back

## Changelog
🆑 Absolucy, PowerfulBacon
fix: Screentip icons work on the latest BYOND 516 again.
/🆑
This commit is contained in:
Lucy
2025-06-11 12:37:30 -04:00
committed by Roxy
parent 48f18c6fbb
commit 9451c0bd46
3 changed files with 0 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
code/__DEFINES/client.dm
View File

@@ -5,11 +5,5 @@
/// Should return the boolean value of the fully_created var, which should be TRUE if New() has finished running. FALSE otherwise. /// Should return the boolean value of the fully_created var, which should be TRUE if New() has finished running. FALSE otherwise.
#define VALIDATE_CLIENT_INITIALIZATION(target) (target.fully_created) #define VALIDATE_CLIENT_INITIALIZATION(target) (target.fully_created)
/// The minimum client BYOND build to disable screentip icons for.
#define MIN_BYOND_BUILD_DISABLE_SCREENTIP_ICONS 1657
/// The maximum client BYOND build to disable screentip icons for.
/// Update this whenever https://www.byond.com/forum/post/2967731 is fixed.
#define MAX_BYOND_BUILD_DISABLE_SCREENTIP_ICONS 1699
/// Aghosting AND APPERANTLY STEALTHMINNING sets your ckey/key == "@[old_key]" because it hates me. this detects that /// Aghosting AND APPERANTLY STEALTHMINNING sets your ckey/key == "@[old_key]" because it hates me. this detects that
#define IS_FAKE_KEY(key) (key && key[1] == "@") #define IS_FAKE_KEY(key) (key && key[1] == "@")

3
code/game/atom/_atom.dm
View File

@@ -886,9 +886,6 @@
if (contextual_screentip_returns & CONTEXTUAL_SCREENTIP_SET) if (contextual_screentip_returns & CONTEXTUAL_SCREENTIP_SET)
var/screentip_images = active_hud.screentip_images var/screentip_images = active_hud.screentip_images
// Disable screentip images for clients affected by https://www.byond.com/forum/post/2967731
if(ISINRANGE(client?.byond_build, MIN_BYOND_BUILD_DISABLE_SCREENTIP_ICONS, MAX_BYOND_BUILD_DISABLE_SCREENTIP_ICONS))
screentip_images = FALSE
// LMB and RMB on one line... // LMB and RMB on one line...
var/lmb_text = build_context(context, SCREENTIP_CONTEXT_LMB, screentip_images) var/lmb_text = build_context(context, SCREENTIP_CONTEXT_LMB, screentip_images)
var/rmb_text = build_context(context, SCREENTIP_CONTEXT_RMB, screentip_images) var/rmb_text = build_context(context, SCREENTIP_CONTEXT_RMB, screentip_images)

BIN
icons/ui/screentips/cursor_hints.dmi
View File

Binary file not shown.
Side by Side Swipe Overlay

Before

Width:  |  Height:  |  Size: 309 B

After

Width:  |  Height:  |  Size: 338 B