From 94ced4ae676a9fd46171c19d6990f06d33e1009c Mon Sep 17 00:00:00 2001 From: SkyratBot <59378654+SkyratBot@users.noreply.github.com> Date: Sat, 29 Jul 2023 06:25:06 +0200 Subject: [PATCH] [MIRROR] Piggyback rides no longer permanently remove your density [MDB IGNORE] (#22754) * Piggyback rides no longer permanently remove your density (#77168) ## About The Pull Request Fixes #77041 Getting onto someone's back would give you "TRAIT_UNDENSE" to stop you from colliding with things your mount could cross. Getting off someone's back would remove "TRAIT_UNDENSE" from the person being ridden. They didn't have the trait, so removing it from them wasn't very useful. ## Why It's Good For The Game This is silly ## Changelog :cl: fix: Dismounting from a piggyback no longer allows you to phase through other players. /:cl: * Piggyback rides no longer permanently remove your density --------- Co-authored-by: Jacquerel --- code/datums/components/riding/riding_mob.dm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/code/datums/components/riding/riding_mob.dm b/code/datums/components/riding/riding_mob.dm index d5098e54c9e..7e98b69e2d6 100644 --- a/code/datums/components/riding/riding_mob.dm +++ b/code/datums/components/riding/riding_mob.dm @@ -216,7 +216,7 @@ unequip_buckle_inhands(parent) var/mob/living/carbon/human/H = parent H.remove_movespeed_modifier(/datum/movespeed_modifier/human_carry) - REMOVE_TRAIT(H, TRAIT_UNDENSE, VEHICLE_TRAIT) + REMOVE_TRAIT(former_rider, TRAIT_UNDENSE, VEHICLE_TRAIT) return ..() /// If the carrier shoves the person they're carrying, force the carried mob off