cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-23 21:18:37 +01:00
Code Issues Packages Projects Releases Wiki Activity

Any unit test that comes after create_and_destroy no longer cares about the floor (#93344)

Browse Source 
## About The Pull Request
`dcs_check_list_arguments` doesn't use the unit test room anyway, nor
should any (so far non-existent) unit test after `create_and_destroy`.
Nonetheless, we cannot enforce these assertions after spawning 99% of
the objects and mobs in the game.

## Why It's Good For The Game
Fixing CI.

## Changelog
N/A
This commit is contained in:
Ghom
2025-10-08 18:09:11 -07:00
committed by GitHub
parent ed946ee324
commit 9519866cf6
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/unit_tests/unit_test.dm
+10 -1
View File
@@ -67,9 +67,14 @@ GLOBAL_VAR_INIT(focused_tests, focused_tests())
uncreatables = build_list_of_uncreatables()
allocated = new
run_loc_floor_bottom_left = get_turf(locate(/obj/effect/landmark/unit_test_bottom_left) in GLOB.landmarks_list)
run_loc_floor_top_right = get_turf(locate(/obj/effect/landmark/unit_test_top_right) in GLOB.landmarks_list)
if(priority > TEST_CREATE_AND_DESTROY) //the create and destroy test WILL wreck havok in the unit test room. You CANNOT stop the inevitable.
return
//Make sure that the top and bottom locations in the diagonal are floors. Anything else may get in the way of several tests.
TEST_ASSERT(isfloorturf(run_loc_floor_bottom_left), "run_loc_floor_bottom_left was not a floor ([run_loc_floor_bottom_left])")
TEST_ASSERT(isfloorturf(run_loc_floor_top_right), "run_loc_floor_top_right was not a floor ([run_loc_floor_top_right])")
@@ -97,6 +102,9 @@ GLOBAL_VAR_INIT(focused_tests, focused_tests())
/// Allocates an instance of the provided type, and places it somewhere in an available loc
/// Instances allocated through this proc will be destroyed when the test is over
/datum/unit_test/proc/allocate(type, ...)
if(priority > TEST_CREATE_AND_DESTROY) //I'm not using TEST_ASSERT here since these are just numbers that tell nothing useful about the problem.
TEST_FAIL("allocate() was called for a unit test after 'create_and_destroy' has finished. The unit test room is no longer a reliable testing ground for atoms.")
return null //you deserve runtime errors for it
var/list/arguments = args.Copy(2)
if(ispath(type, /atom))
if (!arguments.len)
@@ -204,7 +212,8 @@ GLOBAL_VAR_INIT(focused_tests, focused_tests())
else
test.Run()
test.restore_atmos()
if(test.priority < TEST_CREATE_AND_DESTROY) //We shouldn't care about restoring atmos after create_and_destroy.
test.restore_atmos()
duration = REALTIMEOFDAY - duration
GLOB.current_test = null