cleanup _HELPERS/_lists.dm and all the necessary files (#61827)

Bring _HELPERS/_lists.dm to latest standards by:
-Adding proper documentation and fixing existing one
-Giving vars proper names
-Procs now use snake case as per standard (many files that use those procs will be affected)
This commit is contained in:
Ghilker
2021-10-12 14:48:51 +01:00
committed by GitHub
parent 56d21164d0
commit 95c8e00af7
207 changed files with 551 additions and 522 deletions
+1 -1
View File
@@ -104,7 +104,7 @@ GLOBAL_LIST_EMPTY(preferences_datums)
max_save_slots = 8
// give them default keybinds and update their movement keys
key_bindings = deepCopyList(GLOB.default_hotkeys)
key_bindings = deep_copy_list(GLOB.default_hotkeys)
key_bindings_by_key = get_key_bindings_by_key(key_bindings)
randomise = get_default_randomization()
@@ -24,7 +24,7 @@
)
/datum/preference_middleware/keybindings/proc/reset_all_keybinds(list/params, mob/user)
preferences.key_bindings = deepCopyList(GLOB.default_hotkeys)
preferences.key_bindings = deep_copy_list(GLOB.default_hotkeys)
preferences.key_bindings_by_key = preferences.get_key_bindings_by_key(preferences.key_bindings)
preferences.update_static_data(user)
+3 -3
View File
@@ -42,9 +42,9 @@
if (!(TRAIT_NOHUNGER in species.inherent_traits))
diet = list(
"liked_food" = bitfield2list(species.liked_food, food_flags),
"disliked_food" = bitfield2list(species.disliked_food, food_flags),
"toxic_food" = bitfield2list(species.toxic_food, food_flags),
"liked_food" = bitfield_to_list(species.liked_food, food_flags),
"disliked_food" = bitfield_to_list(species.disliked_food, food_flags),
"toxic_food" = bitfield_to_list(species.toxic_food, food_flags),
)
data[species_id] = list(
+1 -1
View File
@@ -188,7 +188,7 @@ SAVEFILE UPDATING/VERSIONING - 'Simplified', or rather, more coder-friendly ~Car
var/datum/outfit/path = text2path(typetext)
if(ispath(path)) //whatever typepath fails this check probably doesn't exist anymore
parsed_favs += path
favorite_outfits = uniqueList(parsed_favs)
favorite_outfits = unique_list(parsed_favs)
// Custom hotkeys
READ_FILE(S["key_bindings"], key_bindings)
+1 -1
View File
@@ -248,7 +248,7 @@ GLOBAL_VAR_INIT(normal_ooc_colour, "#002eb8")
return
// Sort the list
players = sortList(players)
players = sort_list(players)
// Request the player to ignore
var/selection = input("Please, select a player!", "Ignore", null, null) as null|anything in players
+1 -1
View File
@@ -56,7 +56,7 @@
var/num_lines = 0
msg += "<table style='width: 100%; table-layout: fixed'><tr>"
for(var/line in sortList(Lines))
for(var/line in sort_list(Lines))
msg += "<td>[line]</td>"
num_lines += 1