General maintenance for wall mounts (#93534)

## About The Pull Request
- Fixes #93392
- Replaces all custom callbacks with call to `deconstruct()`. The
callbacks weren't necessary as it did the same thing as `deconstruct()`
but in an round about way
- Removed duplicate `Initialize()` procs and the params `building` &
`ndir` from all wall mounts. Makes everything cleaner

## Changelog
🆑
fix: wall mounts placed by player now falls off when the wall they are
mounted on is destroyed
code: cleaned up wall mount code
/🆑
This commit is contained in:
SyncIt21
2025-10-23 20:56:19 +05:30
committed by GitHub
parent d2a9f9b191
commit 9740c687de
39 changed files with 173 additions and 223 deletions
@@ -27,14 +27,14 @@
click_wrapper(attacker, to_smack)
TEST_ASSERT_NOTEQUAL(to_smack.get_integrity(), to_smack.max_integrity, "The barricade should have taken damage a from a non-combat-mode click.")
/// Tests that common tool interactions are possible still, by attempting to open the panel of an air alarm.
/// Tests that common tool interactions are possible still, by attempting to open the panel of an techfab.
/datum/unit_test/machinery_tool_interaction
/datum/unit_test/machinery_tool_interaction/Run()
var/mob/living/carbon/human/consistent/attacker = EASY_ALLOCATE()
var/obj/item/screwdriver/screwdriver = EASY_ALLOCATE()
var/obj/machinery/airalarm/to_smack = EASY_ALLOCATE()
var/obj/machinery/rnd/production/to_smack = EASY_ALLOCATE()
attacker.put_in_active_hand(screwdriver, forced = TRUE)
click_wrapper(attacker, to_smack)
TEST_ASSERT_EQUAL(to_smack.get_integrity(), to_smack.max_integrity, "The air alarm took damage when interacted with a screwdriver.")
TEST_ASSERT(to_smack.panel_open, "The air alarm should have opened its panel after being interacted with a screwdriver.")
TEST_ASSERT_EQUAL(to_smack.get_integrity(), to_smack.max_integrity, "The techfab took damage when interacted with a screwdriver.")
TEST_ASSERT(to_smack.panel_open, "The techfab should have opened its panel after being interacted with a screwdriver.")