[MIRROR] Enforce preserving parent proc return values across ui_act call stacks (#999)

* Enforce preserving parent proc return values across ui_act call stacks (#53964)

All ui_act procs should call parent by default. All procs should preserve the value of the parent proc when it's TRUTHY and pass it down the call stack. No UI should be interactible when its flags or state indicate it should not be, except when explicity overriden by child procs intentionally disregarding parent return values to achieve a specific goal.

* Enforce preserving parent proc return values across ui_act call stacks

Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk>

code/game/objects/items/RPD.dm

@@ -286,8 +286,10 @@ GLOBAL_LIST_INIT(transit_tube_recipes, list(
 	return data
 
 /obj/item/pipe_dispenser/ui_act(action, params)
-	if(..())
+	. = ..()
+	if(.)
 		return
+
 	if(!usr.canUseTopic(src, BE_CLOSE))
 		return
 	var/playeffect = TRUE

code/game/objects/items/airlock_painter.dm

@@ -222,8 +222,10 @@
 	return data
 
 /obj/item/airlock_painter/decal/ui_act(action,list/params)
-	if(..())
+	. = ..()
+	if(.)
 		return
+
 	switch(action)
 		//Lists of decals and designs
 		if("select decal")

code/game/objects/items/crayons.dm

@@ -229,8 +229,10 @@
 	.["current_colour"] = paint_color
 
 /obj/item/toy/crayon/ui_act(action, list/params)
-	if(..())
+	. = ..()
+	if(.)
 		return
+
 	switch(action)
 		if("toggle_cap")
 			if(has_cap)

code/game/objects/items/devices/aicard.dm

@@ -78,7 +78,8 @@
 	return data
 
 /obj/item/aicard/ui_act(action,params)
-	if(..())
+	. = ..()
+	if(.)
 		return
 	switch(action)
 		if("wipe")

code/game/objects/items/devices/portable_chem_mixer.dm

@@ -177,7 +177,8 @@
 	return data
 
 /obj/item/storage/portable_chem_mixer/ui_act(action, params)
-	if(..())
+	. = ..()
+	if(.)
 		return
 	switch(action)
 		if("amount")

code/game/objects/items/devices/radio/electropack.dm

@@ -103,7 +103,8 @@
 	return data
 
 /obj/item/electropack/ui_act(action, params)
-	if(..())
+	. = ..()
+	if(.)
 		return
 
 	switch(action)

code/game/objects/items/devices/radio/radio.dm

@@ -142,7 +142,8 @@
 	return data
 
 /obj/item/radio/ui_act(action, params, datum/tgui/ui)
-	if(..())
+	. = ..()
+	if(.)
 		return
 	switch(action)
 		if("frequency")

code/game/objects/items/devices/traitordevices.dm

@@ -130,7 +130,8 @@ effective or pretty fucking useless.
 	return data
 
 /obj/item/healthanalyzer/rad_laser/ui_act(action, params)
-	if(..())
+	. = ..()
+	if(.)
 		return
 
 	switch(action)

code/game/objects/items/devices/transfer_valve.dm

@@ -210,7 +210,8 @@
 	return data
 
 /obj/item/transfer_valve/ui_act(action, params)
-	if(..())
+	. = ..()
+	if(.)
 		return
 
 	switch(action)

code/game/objects/items/eightball.dm

@@ -217,8 +217,10 @@
 	return data
 
 /obj/item/toy/eightball/haunted/ui_act(action, params)
-	if(..())
+	. = ..()
+	if(.)
 		return
+
 	var/mob/user = usr
 
 	switch(action)

code/game/objects/items/implants/implantchair.dm

@@ -54,7 +54,8 @@
 	return data
 
 /obj/machinery/implantchair/ui_act(action, params)
-	if(..())
+	. = ..()
+	if(.)
 		return
 	switch(action)
 		if("door")

code/game/objects/items/tanks/tanks.dm

@@ -172,7 +172,8 @@
 	return data
 
 /obj/item/tank/ui_act(action, params)
-	if(..())
+	. = ..()
+	if(.)
 		return
 	switch(action)
 		if("pressure")

code/game/objects/items/teleportation.dm

@@ -91,9 +91,6 @@
 		data["trackimplants"] = track_implants
 	return data
 
-/obj/machinery/my_machine/ui_act(action, params)
-  	if(..()) return
-
 /*
  * Hand-tele
  */

code/game/objects/structures.dm

@@ -41,8 +41,8 @@
 		structureclimber.visible_message("<span class='warning'>[structureclimber] is knocked off [src].</span>", "<span class='warning'>You're knocked off [src]!</span>", "<span class='warning'>You see [structureclimber] get knocked off [src].</span>")
 
 /obj/structure/ui_act(action, params)
-	. = ..()
 	add_fingerprint(usr)
+	return ..()
 
 /obj/structure/MouseDrop_T(atom/movable/O, mob/user)
 	. = ..()

code/game/objects/structures/displaycase.dm

@@ -426,7 +426,8 @@
 	return data
 
 /obj/structure/displaycase/forsale/ui_act(action, params)
-	if(..())
+	. = ..()
+	if(.)
 		return
 	var/obj/item/card/id/potential_acc = usr.get_idcard(hand_first = TRUE)
 	switch(action)

code/game/objects/structures/tank_dispenser.dm

@@ -84,7 +84,8 @@
 	return data
 
 /obj/structure/tank_dispenser/ui_act(action, params)
-	if(..())
+	. = ..()
+	if(.)
 		return
 	switch(action)
 		if("plasma")